Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart

Issue 2173373002: Revert "Use Timer and not AnimationFrame during Observatory UI tests" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Revert "Use Timer and not AnimationFrame during Observatory UI tests" Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart b/runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart
index 5ed76a3c89b7b7b4a153c17a26249605aa992485..df83ea482787580effac6bf8ac7b31f3af2a2ef8 100644
--- a/runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart
@@ -4,15 +4,11 @@
import 'dart:html';
import 'package:unittest/unittest.dart';
import 'package:observatory/mocks.dart';
-import 'package:observatory/src/elements/helpers/rendering_queue.dart';
import 'package:observatory/src/elements/nav/class_menu.dart';
main(){
NavClassMenuElement.tag.ensureRegistration();
- final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
- final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
-
final IsolateRefMock i_ref = const IsolateRefMock(id: 'i-id', name: 'i-name');
final ClassRefMock c_ref = const ClassRefMock(id: 'c-id', name: 'c-name');
test('instantiation', () {
@@ -22,8 +18,7 @@ main(){
expect(e.cls, equals(c_ref));
});
test('elements created after attachment', () async {
- final NavClassMenuElement e = new NavClassMenuElement(i_ref, c_ref,
- queue: queue);
+ final NavClassMenuElement e = new NavClassMenuElement(i_ref, c_ref);
document.body.append(e);
await e.onRendered.first;
expect(e.shadowRoot.children.length, isNonZero, reason: 'has elements');

Powered by Google App Engine
This is Rietveld 408576698