third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h - Issue 2173363002: Improve code readibility of PaintPropertyTreeBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h

Issue 2173363002: Improve code readibility of PaintPropertyTreeBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove extra "const" (might be a typo) Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintChunkProperties.h ('k') | third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h

index c0520c27c1eeaa9ec2b7d208df097e05d2840865..dfefef95ac34b406fe4455cb332102c23980cf28 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h

@@ -20,14 +20,14 @@ struct PropertyTreeState {

PropertyTreeState() : PropertyTreeState(nullptr, nullptr, nullptr) {}

PropertyTreeState(

- TransformPaintPropertyNode* transform,

- ClipPaintPropertyNode* clip,

- EffectPaintPropertyNode* effect)

+ const TransformPaintPropertyNode* transform,

+ const ClipPaintPropertyNode* clip,

+ const EffectPaintPropertyNode* effect)

: transform(transform), clip(clip), effect(effect) {}

- RefPtr<TransformPaintPropertyNode> transform;

- RefPtr<ClipPaintPropertyNode> clip;

- RefPtr<EffectPaintPropertyNode> effect;

+ RefPtr<const TransformPaintPropertyNode> transform;

+ RefPtr<const ClipPaintPropertyNode> clip;

+ RefPtr<const EffectPaintPropertyNode> effect;

};

template <class A>