third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp - Issue 2173363002: Improve code readibility of PaintPropertyTreeBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 2173363002: Improve code readibility of PaintPropertyTreeBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove extra "const" (might be a typo) Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/ObjectPaintProperties.h ('k') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

index 5c70cf5be1bd59418a0c903d56a299d566a96bd4..3b685597d828d7be414c0362dd314c82aad40ff1 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

@@ -370,7 +370,7 @@ PaintLayerPainter::PaintResult PaintLayerPainter::paintLayerContents(GraphicsCon

Optional<ScopedPaintChunkProperties> scopedPaintChunkProperties;

if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {

- ObjectPaintProperties* objectPaintProperties = m_paintLayer.layoutObject()->objectPaintProperties();

+ const ObjectPaintProperties* objectPaintProperties = m_paintLayer.layoutObject()->objectPaintProperties();

ASSERT(objectPaintProperties && objectPaintProperties->localBorderBoxProperties());

PaintChunkProperties properties(context.getPaintController().currentPaintChunkProperties());

auto& localBorderBoxProperties = *objectPaintProperties->localBorderBoxProperties();

@@ -693,7 +693,7 @@ void PaintLayerPainter::paintFragmentWithPhase(PaintPhase phase, const PaintLaye

Optional<ScrollRecorder> scrollRecorder;

LayoutPoint paintOffset = -m_paintLayer.layoutBoxLocation();

if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {

- ObjectPaintProperties* objectPaintProperties = m_paintLayer.layoutObject()->objectPaintProperties();

+ const ObjectPaintProperties* objectPaintProperties = m_paintLayer.layoutObject()->objectPaintProperties();

ASSERT(objectPaintProperties && objectPaintProperties->localBorderBoxProperties());

paintOffset += toSize(objectPaintProperties->localBorderBoxProperties()->paintOffset);

} else {