Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2173363002: Improve code readibility of PaintPropertyTreeBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove extra "const" (might be a typo) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index cc8f300d2dbbb26735e8ffbda564a3afbac36aa1..78d02a87c11a1c59fab1f61efe381b2dd8aebd62 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -2641,7 +2641,7 @@ void LayoutObject::willBeDestroyed()
selectionPaintInvalidationMap->remove(this);
if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
- clearObjectPaintProperties();
+ objectPaintPropertiesMap().remove(this);
clearLayoutRootIfNeeded();
@@ -3627,7 +3627,7 @@ void LayoutObject::setIsBackgroundAttachmentFixedObject(bool isBackgroundAttachm
frameView()->removeBackgroundAttachmentFixedObject(this);
}
-ObjectPaintProperties* LayoutObject::objectPaintProperties() const
+const ObjectPaintProperties* LayoutObject::objectPaintProperties() const
{
ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
return objectPaintPropertiesMap().get(this);
@@ -3643,12 +3643,6 @@ ObjectPaintProperties& LayoutObject::ensureObjectPaintProperties()
return *addResult.storedValue->value;
}
-void LayoutObject::clearObjectPaintProperties()
-{
- ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
- objectPaintPropertiesMap().remove(this);
-}
-
} // namespace blink
#ifndef NDEBUG
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/core/layout/api/LayoutItem.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698