Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h

Issue 2173363002: Improve code readibility of PaintPropertyTreeBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h b/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h
index 1020a2075f5daac42b90c354617e84a38ff99269..49a29b5cee16d23f3e0ecc40ed28269d37454530 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h
@@ -22,7 +22,7 @@ namespace blink {
class PLATFORM_EXPORT TransformPaintPropertyNode : public RefCounted<TransformPaintPropertyNode> {
public:
static PassRefPtr<TransformPaintPropertyNode> create(
- PassRefPtr<TransformPaintPropertyNode> parent,
+ const PassRefPtr<const TransformPaintPropertyNode> parent,
jbroman 2016/07/25 17:45:28 It's not idiomatic to pass "const PassRefPtr"; jus
Xianzhu 2016/07/25 18:31:23 Done.
const TransformationMatrix& matrix,
const FloatPoint3D& origin,
bool flattensInheritedTransform = false,
@@ -31,7 +31,7 @@ public:
return adoptRef(new TransformPaintPropertyNode(matrix, origin, parent, flattensInheritedTransform, renderingContextID));
}
- void update(PassRefPtr<TransformPaintPropertyNode> parent, const TransformationMatrix& matrix, const FloatPoint3D& origin, bool flattensInheritedTransform = false, unsigned renderingContextID = 0)
+ void update(PassRefPtr<const TransformPaintPropertyNode> parent, const TransformationMatrix& matrix, const FloatPoint3D& origin, bool flattensInheritedTransform = false, unsigned renderingContextID = 0)
{
m_parent = parent;
m_matrix = matrix;
@@ -45,7 +45,7 @@ public:
// Parent transform that this transform is relative to, or nullptr if this
// is the root transform.
- TransformPaintPropertyNode* parent() const { return m_parent.get(); }
+ const TransformPaintPropertyNode* parent() const { return m_parent.get(); }
// If true, content with this transform node (or its descendant) appears in
// the plane of its parent. This is implemented by flattening the total
@@ -61,7 +61,7 @@ private:
TransformPaintPropertyNode(
const TransformationMatrix& matrix,
const FloatPoint3D& origin,
- PassRefPtr<TransformPaintPropertyNode> parent,
+ PassRefPtr<const TransformPaintPropertyNode> parent,
bool flattensInheritedTransform,
unsigned renderingContextID)
: m_matrix(matrix)
@@ -74,7 +74,7 @@ private:
TransformationMatrix m_matrix;
FloatPoint3D m_origin;
- RefPtr<TransformPaintPropertyNode> m_parent;
+ RefPtr<const TransformPaintPropertyNode> m_parent;
bool m_flattensInheritedTransform;
unsigned m_renderingContextID;
};

Powered by Google App Engine
This is Rietveld 408576698