Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h

Issue 2173363002: Improve code readibility of PaintPropertyTreeBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove extra "const" (might be a typo) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EffectPaintPropertyNode_h 5 #ifndef EffectPaintPropertyNode_h
6 #define EffectPaintPropertyNode_h 6 #define EffectPaintPropertyNode_h
7 7
8 #include "platform/PlatformExport.h" 8 #include "platform/PlatformExport.h"
9 #include "wtf/PassRefPtr.h" 9 #include "wtf/PassRefPtr.h"
10 #include "wtf/RefCounted.h" 10 #include "wtf/RefCounted.h"
11 #include "wtf/RefPtr.h" 11 #include "wtf/RefPtr.h"
12 12
13 #include <iosfwd> 13 #include <iosfwd>
14 14
15 namespace blink { 15 namespace blink {
16 16
17 // A paint effect created by the opacity css property along with a reference to 17 // A paint effect created by the opacity css property along with a reference to
18 // the parent effect node, or nullptr for the root. 18 // the parent effect node, or nullptr for the root.
19 // TODO(pdr): Support more effects than just opacity. 19 // TODO(pdr): Support more effects than just opacity.
20 class PLATFORM_EXPORT EffectPaintPropertyNode : public RefCounted<EffectPaintPro pertyNode> { 20 class PLATFORM_EXPORT EffectPaintPropertyNode : public RefCounted<EffectPaintPro pertyNode> {
21 public: 21 public:
22 static PassRefPtr<EffectPaintPropertyNode> create(PassRefPtr<EffectPaintProp ertyNode> parent, float opacity) 22 static PassRefPtr<EffectPaintPropertyNode> create(PassRefPtr<const EffectPai ntPropertyNode> parent, float opacity)
23 { 23 {
24 return adoptRef(new EffectPaintPropertyNode(parent, opacity)); 24 return adoptRef(new EffectPaintPropertyNode(parent, opacity));
25 } 25 }
26 26
27 void update(PassRefPtr<EffectPaintPropertyNode> parent, float opacity) 27 void update(PassRefPtr<const EffectPaintPropertyNode> parent, float opacity)
28 { 28 {
29 m_parent = parent; 29 m_parent = parent;
30 m_opacity = opacity; 30 m_opacity = opacity;
31 } 31 }
32 32
33 float opacity() const { return m_opacity; } 33 float opacity() const { return m_opacity; }
34 34
35 // Parent effect or nullptr if this is the root effect. 35 // Parent effect or nullptr if this is the root effect.
36 const EffectPaintPropertyNode* parent() const { return m_parent.get(); } 36 const EffectPaintPropertyNode* parent() const { return m_parent.get(); }
37 37
38 private: 38 private:
39 EffectPaintPropertyNode(PassRefPtr<EffectPaintPropertyNode> parent, float op acity) 39 EffectPaintPropertyNode(PassRefPtr<const EffectPaintPropertyNode> parent, fl oat opacity)
40 : m_parent(parent), m_opacity(opacity) { } 40 : m_parent(parent), m_opacity(opacity) { }
41 41
42 RefPtr<EffectPaintPropertyNode> m_parent; 42 RefPtr<const EffectPaintPropertyNode> m_parent;
43 float m_opacity; 43 float m_opacity;
44 }; 44 };
45 45
46 // Redeclared here to avoid ODR issues. 46 // Redeclared here to avoid ODR issues.
47 // See platform/testing/PaintPrinters.h. 47 // See platform/testing/PaintPrinters.h.
48 void PrintTo(const EffectPaintPropertyNode&, std::ostream*); 48 void PrintTo(const EffectPaintPropertyNode&, std::ostream*);
49 49
50 } // namespace blink 50 } // namespace blink
51 51
52 #endif // EffectPaintPropertyNode_h 52 #endif // EffectPaintPropertyNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698