Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2173353002: Simplify ElementVisibilityObserver implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simplify finalization + sync class comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index f8f4ba806168d75890c3c02087971e5f04f3daac..bb0fc955d3aeead2b68a348068ff2f76257cad2e 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -1639,10 +1639,8 @@ void HTMLMediaElement::setReadyState(ReadyState state)
// We might end up in a situation where the previous
// observer didn't had time to fire yet. We can avoid
// creating a new one in this case.
- if (!m_autoplayVisibilityObserver) {
- m_autoplayVisibilityObserver = new ElementVisibilityObserver(this, WTF::bind(&HTMLMediaElement::onVisibilityChangedForAutoplay, wrapWeakPersistent(this)));
- m_autoplayVisibilityObserver->start();
- }
+ if (!m_autoplayVisibilityObserver)
+ m_autoplayVisibilityObserver = ElementVisibilityObserver::create(this, this);
} else {
m_paused = false;
invalidateCachedTime();
@@ -3671,8 +3669,8 @@ DEFINE_TRACE(HTMLMediaElement)
visitor->trace(m_srcObject);
visitor->trace(m_autoplayVisibilityObserver);
visitor->template registerWeakMembers<HTMLMediaElement, &HTMLMediaElement::clearWeakMembers>(this);
- Supplementable<HTMLMediaElement>::trace(visitor);
HTMLElement::trace(visitor);
+ Supplementable<HTMLMediaElement>::trace(visitor);
ActiveDOMObject::trace(visitor);
}
@@ -3910,7 +3908,7 @@ void HTMLMediaElement::recordAutoplayUnmuteStatus(AutoplayUnmuteActionStatus sta
autoplayUnmuteHistogram.count(status);
}
-void HTMLMediaElement::onVisibilityChangedForAutoplay(bool isVisible)
+void HTMLMediaElement::onVisibilityChanged(bool isVisible)
{
if (!isVisible)
return;

Powered by Google App Engine
This is Rietveld 408576698