Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: go/src/infra/tools/kitchen/cook.go

Issue 2173313002: kitchen: fix emission of annotations (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/tools/kitchen/cook.go
diff --git a/go/src/infra/tools/kitchen/cook.go b/go/src/infra/tools/kitchen/cook.go
index 17b41f4757bd7aee2005d4c52ef14555331bff92..84198bf2e14be5ebb4f141563212ddb39c3b3e2f 100644
--- a/go/src/infra/tools/kitchen/cook.go
+++ b/go/src/infra/tools/kitchen/cook.go
@@ -227,11 +227,14 @@ func (c *cookRun) Run(a subcommands.Application, args []string) (exitCode int) {
// Relevant code:
// https://chromium.googlesource.com/chromium/tools/depot_tools/+/248331450c05c59c8e966c806f00bd2475e36603/recipe_modules/infra_paths/api.py#12
// https://chromium.googlesource.com/chromium/tools/depot_tools/+/248331450c05c59c8e966c806f00bd2475e36603/recipe_modules/infra_paths/path_config.py#57
+ if _, ok := props["path_config"]; ok {
+ fmt.Fprintln(os.Stderr, `"path_config" property must not be set; it is reserved by kitchen`)
+ }
props["path_config"] = "swarmbucket"
// If we're not using LogDog, send out annotations.
bootstapSuccess := true
- if !c.logdog.emitAnnotations() {
+ if c.logdog.emitAnnotations() {
if c.Timestamps {
annotateTime(ctx)
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698