Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2173283002: Revert of Fix typo in printing.gyp (Closed)

Created:
4 years, 5 months ago by skau
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, emircan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix typo in printing.gyp (patchset #3 id:40001 of https://codereview.chromium.org/2170123003/ ) Reason for revert: Breaks Win8 GYP https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/978 Fix before relanding. Original issue's description: > Fix GYP build for Chrome OS to match GN > > Fix type in printing.gyp: printing/backend/cups_deleter{,s}.{h,cc} > > Disable the cloud print connector like in GN in chrome.gyp > > BUG=630791 > > TEST=Ran `GYP_CHROMIUM_NO_ACTION=0 gclient sync` and verified that chrome compiles > > Committed: https://crrev.com/d9e819815d379eb2492514ddb8158def89314311 > Cr-Commit-Position: refs/heads/master@{#407317} TBR=emircan@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M chrome/chrome.gyp View 2 chunks +6 lines, -6 lines 0 comments Download
M printing/printing.gyp View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
skau
Created Revert of Fix typo in printing.gyp
4 years, 5 months ago (2016-07-23 02:54:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173283002/1
4 years, 5 months ago (2016-07-23 02:54:38 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 02:54:40 UTC) #5
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698