Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 2173233002: [DevTools] Better locations for snippets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
index dafe5231b86d811ed7385eb1fbe31d6da67a1a34..243c155357e296815d346d11bfff3f2640f4654c 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
@@ -67,7 +67,7 @@ WebInspector.PresentationConsoleMessageHelper.prototype = {
*/
_consoleMessageAdded: function(message)
{
- if (!message.url || !message.isErrorOrWarning())
+ if (!message.isErrorOrWarning())
return;
var rawLocation = this._rawLocation(message);
@@ -86,14 +86,14 @@ WebInspector.PresentationConsoleMessageHelper.prototype = {
var debuggerModel = WebInspector.DebuggerModel.fromTarget(message.target());
if (!debuggerModel)
return null;
+ if (message.scriptId)
+ return debuggerModel.createRawLocationByScriptId(message.scriptId, message.line, message.column);
var callFrame = message.stackTrace && message.stackTrace.callFrames ? message.stackTrace.callFrames[0] : null;
- var lineNumber = callFrame ? callFrame.lineNumber : message.line;
- var columnNumber = callFrame ? callFrame.columnNumber : message.column;
if (callFrame)
- columnNumber = callFrame.columnNumber;
- if (message.scriptId)
- return debuggerModel.createRawLocationByScriptId(message.scriptId, lineNumber, columnNumber);
- return debuggerModel.createRawLocationByURL(message.url || "", lineNumber, columnNumber);
+ return debuggerModel.createRawLocationByScriptId(callFrame.scriptId, callFrame.lineNumber, callFrame.columnNumber);
+ if (message.url)
+ return debuggerModel.createRawLocationByURL(message.url, message.line, message.column);
+ return null;
},
/**

Powered by Google App Engine
This is Rietveld 408576698