[DevTools] Better locations for snippets

third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 49 matching lines @@
     {
         var message = /** @type {!WebInspector.ConsoleMessage} */ (event.data);
         this._consoleMessageAdded(message);
     },
 
     /**
      * @param {!WebInspector.ConsoleMessage} message
      */
     _consoleMessageAdded: function(message)
     {
-        if (!message.url || !message.isErrorOrWarning())
+        if (!message.isErrorOrWarning())
             return;
 
         var rawLocation = this._rawLocation(message);
         if (rawLocation)
             this._addConsoleMessageToScript(message, rawLocation);
         else
             this._addPendingConsoleMessage(message);
     },
 
     /**
      * @param {!WebInspector.ConsoleMessage} message
      * @return {?WebInspector.DebuggerModel.Location}
      */
     _rawLocation: function(message)
     {
         var debuggerModel = WebInspector.DebuggerModel.fromTarget(message.target());
         if (!debuggerModel)
             return null;
+        if (message.scriptId)
+            return debuggerModel.createRawLocationByScriptId(message.scriptId, message.line, message.column);
         var callFrame = message.stackTrace && message.stackTrace.callFrames ? message.stackTrace.callFrames[0] : null;
-        var lineNumber = callFrame ? callFrame.lineNumber : message.line;
-        var columnNumber = callFrame ? callFrame.columnNumber : message.column;
         if (callFrame)
-            columnNumber = callFrame.columnNumber;
-        if (message.scriptId)
-            return debuggerModel.createRawLocationByScriptId(message.scriptId, lineNumber, columnNumber);
-        return debuggerModel.createRawLocationByURL(message.url || "", lineNumber, columnNumber);
+            return debuggerModel.createRawLocationByScriptId(callFrame.scriptId, callFrame.lineNumber, callFrame.columnNumber);
+        if (message.url)
+            return debuggerModel.createRawLocationByURL(message.url, message.line, message.column);
+        return null;
     },
 
     /**
      * @param {!WebInspector.ConsoleMessage} message
      * @param {!WebInspector.DebuggerModel.Location} rawLocation
      */
     _addConsoleMessageToScript: function(message, rawLocation)
     {
         this._presentationConsoleMessages.push(new WebInspector.PresentationConsoleMessage(message, rawLocation, this._locationPool));
     },
@@ skipping 83 matching lines @@
 
     dispose: function()
     {
         if (this._uiMessage)
             this._uiMessage.remove();
     }
 }
 
 /** @type {!WebInspector.PresentationConsoleMessageHelper} */
 WebInspector.presentationConsoleMessageHelper;