Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 217323011: Apply OwnPtr|PassOwnPtr to handle member variables and arguments in SpeechRecognitionClient|Control… (Closed)

Created:
6 years, 8 months ago by gyuyoung-inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Apply OwnPtr|PassOwnPtr to handle member variables and arguments in SpeechRecognitionClient|Controller WebViewImpl has used m_midiClientProxy unnecessarily in order to pass it to provideSpeechRecognitionTo(). To remove it, this cl changes the parameter type to OwnPtr|PassOwnPtr in SpeechRecognitionClient and SpeechRecognitionControler classes. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170726

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M Source/modules/speech/SpeechRecognitionClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionController.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionController.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
gyuyoung-inactive
6 years, 8 months ago (2014-04-02 03:56:45 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-02 03:58:55 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-02 09:27:34 UTC) #3
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-02 09:53:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/217323011/1
6 years, 8 months ago (2014-04-02 09:53:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 11:02:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 11:02:55 UTC) #7
gyuyoung-inactive
On 2014/04/02 11:02:55, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 8 months ago (2014-04-02 11:10:18 UTC) #8
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-02 11:10:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/217323011/1
6 years, 8 months ago (2014-04-02 11:10:47 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 12:20:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 12:20:46 UTC) #12
gyuyoung-inactive
On 2014/04/02 12:20:46, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 8 months ago (2014-04-02 12:40:43 UTC) #13
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-02 12:43:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/217323011/20001
6 years, 8 months ago (2014-04-02 12:44:05 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 15:16:52 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 15:16:53 UTC) #17
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-03 01:13:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/217323011/20001
6 years, 8 months ago (2014-04-03 01:14:06 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 03:46:34 UTC) #20
Message was sent while issue was closed.
Change committed as 170726

Powered by Google App Engine
This is Rietveld 408576698