ResizeObserver pt3: observation computation

ResizeObserver pt3: observation computation

This patch fills in ResizeObservation functionality:
- computing/setting observation size
- determining target depth

ResizeObservation::getTargetSize is static because it will also
get used by ResizeObserverEntry

I've also included basic C++ tests.

BUG=612962
Committed: https://crrev.com/03e20c08515f228ac05c74aca0645d3bf6ab1598
Cr-Commit-Position: refs/heads/master@{#407736}

[atotic1, 2016-07-22 19:16:42]

Description was changed from

==========
ResizeObserver pt3: observation computation

BUG=612962
==========

to

==========
ResizeObserver pt3: observation computation

This patch fills in ResizeObservation functionality:
- computing/setting observation size
- determining target depth

ResizeObservation::getTargetSize is static because it will also
get used by ResizeObserverEntry 

I've also included basic C++ tests.

BUG=612962
==========

[atotic1, 2016-07-22 19:16:43]

atotic@google.com changed reviewers:
+ eae@chromium.org, esprehn@chromium.org

[atotic1, 2016-07-22 19:17:15]

Here is my 3rd ResizeObserver patch, please review.

[eae, 2016-07-22 20:22:33]

https://codereview.chromium.org/2173203002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/observer/ResizeObservation.cpp (right):

https://codereview.chromium.org/2173203002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/observer/ResizeObservation.cpp:45: return
LayoutSize(svg.getBBox().size());
You probably want roundedLayoutSize(svg.getBBox().size())
LayoutSize(FloatSize) floors

[atotic1, 2016-07-22 21:07:32]

On 2016/07/22 20:22:33, eae wrote:
>
https://codereview.chromium.org/2173203002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/observer/ResizeObservation.cpp (right):
> 
>
https://codereview.chromium.org/2173203002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/observer/ResizeObservation.cpp:45: return
> LayoutSize(svg.getBBox().size());
> You probably want roundedLayoutSize(svg.getBBox().size())
> LayoutSize(FloatSize) floors

I am having trouble understanding the difference:

This is what I think current code does:

svg.getBBox().size() returns FloatSize.

LayoutSize(FloatSize) would call:
explicit LayoutSize(const FloatSize& size) : m_width(size.width()),
m_height(size.height()) { }

inline LayoutSize roundedLayoutSize(const FloatSize& s)
{
    return LayoutSize(s);
}

which would call the same function.

Also, nothing else in our codebase calls roundedLayoutSize.

Please advise,

[eae, 2016-07-22 21:08:33]

Oh, you're right. It used to do something different.

Never mind then. LGTM

[esprehn, 2016-07-25 21:52:08]

lgtm

[atotic1, 2016-07-25 21:53:08]

The CQ bit was checked by atotic@google.com

[commit-bot: I haz the power, 2016-07-25 21:53:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 22:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 22:19:51]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[atotic1, 2016-07-25 22:35:05]

The CQ bit was checked by atotic@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 22:35:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 23:38:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 23:38:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[atotic1, 2016-07-26 05:27:36]

The CQ bit was checked by atotic@google.com

[atotic1, 2016-07-26 05:27:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2173203002/#ps20001
(title: "Added missing CORE_EXPORT")

[commit-bot: I haz the power, 2016-07-26 05:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 08:29:22]

Description was changed from

==========
ResizeObserver pt3: observation computation

This patch fills in ResizeObservation functionality:
- computing/setting observation size
- determining target depth

ResizeObservation::getTargetSize is static because it will also
get used by ResizeObserverEntry 

I've also included basic C++ tests.

BUG=612962
==========

to

==========
ResizeObserver pt3: observation computation

This patch fills in ResizeObservation functionality:
- computing/setting observation size
- determining target depth

ResizeObservation::getTargetSize is static because it will also
get used by ResizeObserverEntry 

I've also included basic C++ tests.

BUG=612962
==========

[commit-bot: I haz the power, 2016-07-26 08:29:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 08:31:21]

Description was changed from

==========
ResizeObserver pt3: observation computation

This patch fills in ResizeObservation functionality:
- computing/setting observation size
- determining target depth

ResizeObservation::getTargetSize is static because it will also
get used by ResizeObserverEntry 

I've also included basic C++ tests.

BUG=612962
==========

to

==========
ResizeObserver pt3: observation computation

This patch fills in ResizeObservation functionality:
- computing/setting observation size
- determining target depth

ResizeObservation::getTargetSize is static because it will also
get used by ResizeObserverEntry

I've also included basic C++ tests.

BUG=612962

Committed: https://crrev.com/03e20c08515f228ac05c74aca0645d3bf6ab1598
Cr-Commit-Position: refs/heads/master@{#407736}
==========

[commit-bot: I haz the power, 2016-07-26 08:31:23]

Patchset 2 (id:??) landed as
https://crrev.com/03e20c08515f228ac05c74aca0645d3bf6ab1598
Cr-Commit-Position: refs/heads/master@{#407736}