Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2173163003: [css-tables] Mark sibling cells dirty when a cell is removed (Closed)

Created:
4 years, 5 months ago by dgrogan
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-tables] Mark sibling cells dirty when a cell is removed Cells's border boxes were not getting resized when their collapsed border changed because a sibling was removed. BUG=613728 Committed: https://crrev.com/4f82f2cf4077cb507ed9c8ab7a577073bf9d8eb6 Cr-Commit-Position: refs/heads/master@{#407339}

Patch Set 1 #

Patch Set 2 : rebase the paint test #

Patch Set 3 : mark fast/repaint/table-collapsed-border.html NeedsRebaseline #

Messages

Total messages: 18 (9 generated)
dgrogan
4 years, 5 months ago (2016-07-22 18:55:21 UTC) #2
eae
OK, LGTM
4 years, 5 months ago (2016-07-22 18:56:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173163003/1
4 years, 5 months ago (2016-07-22 18:57:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/260824)
4 years, 5 months ago (2016-07-22 20:24:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173163003/20001
4 years, 5 months ago (2016-07-22 20:53:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/109305)
4 years, 5 months ago (2016-07-22 22:18:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173163003/40001
4 years, 5 months ago (2016-07-22 23:35:43 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-23 03:37:06 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 03:38:17 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f82f2cf4077cb507ed9c8ab7a577073bf9d8eb6
Cr-Commit-Position: refs/heads/master@{#407339}

Powered by Google App Engine
This is Rietveld 408576698