Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: components/arc/common/auth.mojom

Issue 2173103002: Recategorize ARC auth sign in errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/common/auth.mojom
diff --git a/components/arc/common/auth.mojom b/components/arc/common/auth.mojom
index 503cb3615f08997216ca32f62a90c683828612db..e4dca7328b3f094cad454de185815dfb3d311f8d 100644
--- a/components/arc/common/auth.mojom
+++ b/components/arc/common/auth.mojom
@@ -5,13 +5,59 @@
module arc.mojom;
// These values describe failure reason of sign-in.
+[Extensible]
enum ArcSignInFailureReason {
+ // Negative values are reserved for internal use.
+ // The values are shuffled to keep the backward compatibility.
+ // Next value: 15.
UNKNOWN_ERROR = 0,
- NETWORK_ERROR = 1,
- SERVICE_UNAVAILABLE = 2,
- BAD_AUTHENTICATION = 3,
- GMS_CORE_NOT_AVAILABLE = 4,
- CLOUD_PROVISION_FLOW_FAIL = 5,
+
+ // Mojo errors:
+ // MOJO_VERSION_MISMATCH: is sent when an API is not supported
+ // due to Host/Instance version mismatch.
+ // MOJO_CALL_TIMEOUT: is sent when a Mojo invocation is started
+ // but not completed with time out.
+ MOJO_VERSION_MISMATCH = 6,
+ MOJO_CALL_TIMEOUT = 7,
+
+ // Device check-in errors:
+ // DEVICE_CHECK_IN_FAILED: is sent when "check-in" procedure is completed
+ // but is actually failed.
+ // DEVICE_CHECK_IN_TIMEOUT: is sent when "check-in" procedure started
+ // but is not completed.
+ // DEVICE_CHECK_IN_INTERNAL_ERROR: is sent when "check-in" procedure is
+ // started, but some unexpected error situation happens so that it could
+ // not completed.
+ DEVICE_CHECK_IN_FAILED = 4,
+ DEVICE_CHECK_IN_TIMEOUT = 8,
+ DEVICE_CHECK_IN_INTERNAL_ERROR = 9,
+
+ // GMS errors:
+ // GMS_NETWORK_ERROR: is sent when GMS sign-in procedure is started, but
+ // it reports NETWORK_ERROR.
+ // GMS_SERVICE_UNAVAILABLE: is sent when GMS sign-in procedure is started
+ // but it reports SERVICE_UNAVAILABLE. Note that this is not generic
+ // service unavailable error code.
+ // GMS_BAD_AUTHENTICATION: is sent when GMS sign-in procedure is started
+ // but it reports BAD_AUTHENTICATION.
+ // GMS_SIGN_IN_FAILED: is sent when GMS sign in procedure is started but
+ // it reports an error other than above NETWORK_ERROR, SERVICE_UNAVAILABLE
+ // or BAD_AUTHENTICATION. In general, we do not expect this kind of cases.
+ // GMS_SIGN_IN_TIMEOUT: is sent when GMS sign in procedure is started but
+ // not returned.
+ // GMS_SIGN_IN_INTERNAL_ERROR: is sent when GMS sign in procedure is started
+ // but could not completed.
+ GMS_NETWORK_ERROR = 1,
+ GMS_SERVICE_UNAVAILABLE = 2,
+ GMS_BAD_AUTHENTICATION = 3,
+ GMS_SIGN_IN_FAILED = 10,
+ GMS_SIGN_IN_TIMEOUT = 11,
+ GMS_SIGN_IN_INTERNAL_ERROR = 12,
+
+ // Cloud provisioning errors.
+ CLOUD_PROVISION_FLOW_FAILED = 5,
+ CLOUD_PROVISION_FLOW_TIMEOUT = 13,
+ CLOUD_PROVISION_FLOW_INTERNAL_ERROR = 14,
};
interface AuthHost {
« chrome/browser/chromeos/arc/arc_optin_uma.h ('K') | « chrome/browser/chromeos/arc/arc_optin_uma.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698