chrome/browser/chromeos/arc/arc_auth_service_unittest.cc - Issue 2173103002: Recategorize ARC auth sign in errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service_unittest.cc

Issue 2173103002: Recategorize ARC auth sign in errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/arc/arc_auth_service_unittest.cc

diff --git a/chrome/browser/chromeos/arc/arc_auth_service_unittest.cc b/chrome/browser/chromeos/arc/arc_auth_service_unittest.cc

index 527dacdfdb8283b9903b63dbd24eb958037f2377..6f67ed827825a16179d670a4bd3327cfdf5a7ef4 100644

--- a/chrome/browser/chromeos/arc/arc_auth_service_unittest.cc

+++ b/chrome/browser/chromeos/arc/arc_auth_service_unittest.cc

@@ -294,7 +294,8 @@ TEST_F(ArcAuthServiceTest, SignInStatus) {

EXPECT_TRUE(bridge_service()->ready());

// Report failure.

- auth_service()->OnSignInFailed(mojom::ArcSignInFailureReason::NETWORK_ERROR);

+ auth_service()->OnSignInFailed(

+ mojom::ArcSignInFailureReason::GMS_NETWORK_ERROR);

EXPECT_FALSE(prefs->GetBoolean(prefs::kArcSignedIn));

EXPECT_EQ(ArcAuthService::State::STOPPED, auth_service()->state());

EXPECT_FALSE(bridge_service()->ready());