Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2173063002: Fix printing.gyp by joining two 'conditions' dicts together. (Closed)

Created:
4 years, 5 months ago by Alexander Potapenko
Modified:
4 years, 5 months ago
Reviewers:
skau
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix printing.gyp by joining two 'conditions' dicts together. Revision b779ce61d5369a930af480c265c0c5b924888914 broke the generate_build_files step on the Dr. Memory build: gyp: Key 'conditions' repeated at level 6 with key path 'targets.0.conditions.5.1' while reading C:\b\build\slave\drm-cr\build\src\printing\printing.gyp BUG=607668 TEST=none TBR=skau@chromium.org Committed: https://crrev.com/700090668633cb92bf3705d4270920a7917204f1 Cr-Commit-Position: refs/heads/master@{#407160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M printing/printing.gyp View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Alexander Potapenko
TBR
4 years, 5 months ago (2016-07-22 14:16:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173063002/1
4 years, 5 months ago (2016-07-22 14:17:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 14:55:45 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/700090668633cb92bf3705d4270920a7917204f1 Cr-Commit-Position: refs/heads/master@{#407160}
4 years, 5 months ago (2016-07-22 14:57:34 UTC) #9
skau
4 years, 5 months ago (2016-07-22 20:17:12 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698