ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h - Issue 2173033002: Make various views SetShape() methods take an unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Issue 2173033002: Make various views SetShape() methods take an unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc ('k') | ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

index aced1ef5ede25e998c2693ef0a584b6c965e7024..b648c0062a7517f66db480ce0221e8f825effacd 100644

--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

@@ -111,7 +111,7 @@ class VIEWS_EXPORT DesktopWindowTreeHostX11

gfx::Rect GetRestoredBounds() const override;

std::string GetWorkspace() const override;

gfx::Rect GetWorkAreaBoundsInScreen() const override;

- void SetShape(SkRegion* native_region) override;

+ void SetShape(std::unique_ptr<SkRegion> native_region) override;

void Activate() override;

void Deactivate() override;

bool IsActive() const override;