chrome/browser/ui/views/apps/chrome_native_app_window_views.cc - Issue 2173033002: Make various views SetShape() methods take an unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

Issue 2173033002: Make various views SetShape() methods take an unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

index d39003088a92636d78525186ede593f141b4635d..97ac593170b6863382568a7e70a75196c141e5f3 100644

--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

@@ -354,7 +354,8 @@ bool ChromeNativeAppWindowViews::IsFullscreenOrPending() const {

void ChromeNativeAppWindowViews::UpdateShape(std::unique_ptr<SkRegion> region) {

shape_ = std::move(region);

- widget()->SetShape(shape() ? new SkRegion(*shape()) : nullptr);

+ widget()->SetShape(

+ base::WrapUnique(shape() ? new SkRegion(*shape()) : nullptr));

sadrul 2016/07/23 00:59:16 This could also be: shape() ? base::MakeUnique<

Lei Zhang 2016/07/25 17:57:00 Done.

widget()->OnSizeConstraintsChanged();

}

« no previous file with comments | « no previous file | ui/views/mus/native_widget_mus.h » ('j') | ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc » ('J')