Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 217303002: Adds power state suspend/resume messages to the webrtc native log. (Closed)

Created:
6 years, 9 months ago by jiayl
Modified:
6 years, 9 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds power state suspend/resume messages to the webrtc native log. BUG=357683 NOTRY=true TESTED= try jobs passed Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260305

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comments #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M content/browser/renderer_host/media/media_stream_manager.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 2 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
jiayl
PTAL
6 years, 9 months ago (2014-03-28 18:10:45 UTC) #1
jiayl
On 2014/03/28 18:10:45, jiayl wrote: > PTAL Verified on Mac by closing/opening the lid.
6 years, 9 months ago (2014-03-28 18:21:19 UTC) #2
vrk (LEFT CHROMIUM)
lgtm https://codereview.chromium.org/217303002/diff/1/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/217303002/diff/1/content/browser/renderer_host/media/media_stream_manager.cc#newcode358 content/browser/renderer_host/media/media_stream_manager.cc:358: base::PowerMonitor* power_monitor = base::PowerMonitor::Get(); Can you add a ...
6 years, 9 months ago (2014-03-28 18:29:46 UTC) #3
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 9 months ago (2014-03-28 18:33:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/217303002/20001
6 years, 9 months ago (2014-03-28 18:37:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 20:00:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-28 20:00:36 UTC) #7
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 9 months ago (2014-03-28 20:10:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/217303002/20001
6 years, 9 months ago (2014-03-28 20:14:55 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 20:34:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-28 20:34:40 UTC) #11
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 9 months ago (2014-03-28 21:11:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/217303002/40001
6 years, 9 months ago (2014-03-28 21:12:56 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 23:45:02 UTC) #14
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 23:45:03 UTC) #15
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 9 months ago (2014-03-28 23:47:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/217303002/40001
6 years, 9 months ago (2014-03-28 23:50:24 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 23:54:45 UTC) #18
Message was sent while issue was closed.
Change committed as 260305

Powered by Google App Engine
This is Rietveld 408576698