Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2172943002: Convert editing/deleting/delete-tab-[1234].html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/delete-tab-[1234].html to use w3c test harness This patch converts "editing/deleting/delete-tab-[1234].html" to use w3c test harness and consolidates into "delete_tab.html" to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/ee02461978cc4c62832472126900f9b868e04153 Cr-Commit-Position: refs/heads/master@{#407085}

Patch Set 1 : 2016-07-22T14:23:00 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -439 lines) Patch
D third_party/WebKit/LayoutTests/editing/deleting/delete-tab-001.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-tab-002.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-tab-003.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-tab-004.html View 1 chunk +0 lines, -36 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/deleting/delete_tab.html View 1 chunk +58 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-001-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-002-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-003-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-004-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-001-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-002-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-003-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-004-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-001-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-002-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-003-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-004-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-22 05:40:24 UTC) #5
yoichio
lgtm
4 years, 5 months ago (2016-07-22 06:38:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172943002/1
4 years, 5 months ago (2016-07-22 06:44:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 06:48:18 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 06:50:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee02461978cc4c62832472126900f9b868e04153
Cr-Commit-Position: refs/heads/master@{#407085}

Powered by Google App Engine
This is Rietveld 408576698