Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2172933003: Remove unused ContentBrowserClient::IsFastShutdownPossible. (Closed)

Created:
4 years, 5 months ago by jam
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, android-webview-reviews_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused ContentBrowserClient::IsFastShutdownPossible. Committed: https://crrev.com/34ac57510afb340a041fd5cb65ca9df072e0083a Cr-Commit-Position: refs/heads/master@{#407542}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
jam
4 years, 5 months ago (2016-07-22 23:17:21 UTC) #6
Avi (use Gerrit)
lgtm Are we really getting rid of slow shutdown? 🎉
4 years, 5 months ago (2016-07-23 03:53:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172933003/1
4 years, 5 months ago (2016-07-25 17:02:54 UTC) #9
jam
On 2016/07/23 03:53:38, Avi wrote: > lgtm > > Are we really getting rid of ...
4 years, 5 months ago (2016-07-25 17:03:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/40749) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-25 17:04:56 UTC) #12
Avi (use Gerrit)
On 2016/07/25 17:03:03, jam wrote: > On 2016/07/23 03:53:38, Avi wrote: > > lgtm > ...
4 years, 5 months ago (2016-07-25 17:37:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172933003/20001
4 years, 5 months ago (2016-07-25 17:56:52 UTC) #16
jam
On 2016/07/25 17:37:39, Avi wrote: > On 2016/07/25 17:03:03, jam wrote: > > On 2016/07/23 ...
4 years, 5 months ago (2016-07-25 17:57:15 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-25 19:15:46 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 19:18:26 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34ac57510afb340a041fd5cb65ca9df072e0083a
Cr-Commit-Position: refs/heads/master@{#407542}

Powered by Google App Engine
This is Rietveld 408576698