Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2172933002: Open the notification URL (not the web app start_url) when deep-linking into standalone mode. (Closed)

Created:
4 years, 5 months ago by dominickn
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Open the notification URL (not the web app start_url) when deep-linking into standalone mode. When deep-linking into a standalone web app from a notification, the app's start_url is always opened and the URL that the notification wants to open is ignored. This CL fixes the bug by injecting the notification URL in place of the web app URL when deep-linking. We also force a reload of the web app if it is already running to ensure that the desired url is loaded. Replacing the URL in this manner is correct as the notification URL is guaranteed to live within the web app's scope for notification deep-linking to trigger. BUG=627791 Review-Url: https://codereview.chromium.org/2145833003 Cr-Commit-Position: refs/heads/master@{#405638} (cherry picked from commit e10048ec434da0f56f6b2c5579bdbee2fa06654d) Committed: https://chromium.googlesource.com/chromium/src/+/a681341f2addfd0fd3f59443fbd8a57ec651f0c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominickn
4 years, 5 months ago (2016-07-22 03:28:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a681341f2addfd0fd3f59443fbd8a57ec651f0c2.

Powered by Google App Engine
This is Rietveld 408576698