Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 217293002: Remove WebSetting::setFullScreenEnabled (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Remove WebSetting::setFullScreenEnabled It is no longer called from Chromium: https://codereview.chromium.org/216233008/ BUG=344002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
PTAL. Depends on https://codereview.chromium.org/216233008/ to land first.
6 years, 8 months ago (2014-03-28 18:06:26 UTC) #1
eseidel
lgtm
6 years, 8 months ago (2014-03-28 18:31:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/217293002/1
6 years, 8 months ago (2014-03-28 18:31:59 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 18:32:26 UTC) #4
commit-bot: I haz the power
Failed to apply patch for public/web/WebSettings.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-03-28 18:32:27 UTC) #5
philipj_slow
I'll commit this when the dependencies have landed.
6 years, 8 months ago (2014-03-28 18:35:21 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 8 months ago (2014-03-31 13:21:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/217293002/1
6 years, 8 months ago (2014-03-31 13:22:00 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 14:30:33 UTC) #9
Message was sent while issue was closed.
Change committed as 170446

Powered by Google App Engine
This is Rietveld 408576698