Reuse sampler descriptor set allocations in Vulkan

Reuse sampler descriptor set allocations in Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2172873003

Committed: https://skia.googlesource.com/skia/+/707bbd622b425d5edc96f06580d5ddd3d9cbeb3e

[egdaniel, 2016-07-22 20:55:01]

Description was changed from

==========
Reuse sampler descriptor set allocations in Vulkan

BUG=skia:
==========

to

==========
Reuse sampler descriptor set allocations in Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2172873003
==========

[egdaniel, 2016-07-25 14:09:15]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[egdaniel, 2016-07-25 14:09:16]

This causes us to make about 10% of the sampler DS allocations as we do
currently

[jvanverth1, 2016-07-25 19:12:56]

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkDescript...
File src/gpu/vk/GrVkDescriptorSetManager.cpp (right):

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkDescript...
src/gpu/vk/GrVkDescriptorSetManager.cpp:78: VkDescriptorSetLayout
GrVkDescriptorSetManager::layout() const { return fPoolManager.fDescLayout; }
Put in .h file?

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkDescript...
src/gpu/vk/GrVkDescriptorSetManager.cpp:143: GR_VK_CALL(gpu->vkInterface(),
DestroyDescriptorSetLayout(gpu->device(), fDescLayout,
Is there any way to create this in the DescriptorPoolManager? It seems this
should be created and destroyed in the same code area.

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkUniformH...
File src/gpu/vk/GrVkUniformHandler.h (right):

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkUniformH...
src/gpu/vk/GrVkUniformHandler.h:93: friend class GrVkResourceProvider;
This is getting awfully friendly -- is there another way to do this?

[egdaniel, 2016-07-26 13:33:19]

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkDescript...
File src/gpu/vk/GrVkDescriptorSetManager.cpp (right):

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkDescript...
src/gpu/vk/GrVkDescriptorSetManager.cpp:78: VkDescriptorSetLayout
GrVkDescriptorSetManager::layout() const { return fPoolManager.fDescLayout; }
On 2016/07/25 19:12:56, jvanverth1 wrote:
> Put in .h file?

Done.

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkDescript...
src/gpu/vk/GrVkDescriptorSetManager.cpp:143: GR_VK_CALL(gpu->vkInterface(),
DestroyDescriptorSetLayout(gpu->device(), fDescLayout,
On 2016/07/25 19:12:56, jvanverth1 wrote:
> Is there any way to create this in the DescriptorPoolManager? It seems this
> should be created and destroyed in the same code area.

Done.

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkUniformH...
File src/gpu/vk/GrVkUniformHandler.h (right):

https://codereview.chromium.org/2172873003/diff/40001/src/gpu/vk/GrVkUniformH...
src/gpu/vk/GrVkUniformHandler.h:93: friend class GrVkResourceProvider;
On 2016/07/25 19:12:56, jvanverth1 wrote:
> This is getting awfully friendly -- is there another way to do this?

Well one went away :), leaving the other as we discussed.

[jvanverth1, 2016-07-26 13:54:43]

lgtm

[egdaniel, 2016-07-26 13:55:35]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-07-26 13:55:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 14:19:49]

Description was changed from

==========
Reuse sampler descriptor set allocations in Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2172873003
==========

to

==========
Reuse sampler descriptor set allocations in Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2172873003

Committed:
https://skia.googlesource.com/skia/+/707bbd622b425d5edc96f06580d5ddd3d9cbeb3e
==========

[commit-bot: I haz the power, 2016-07-26 14:19:51]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/707bbd622b425d5edc96f06580d5ddd3d9cbeb3e