Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2172863002: [IndexedDB]: Passing URLRequestContextGetter. (Closed)

Created:
4 years, 5 months ago by cmumford
Modified:
4 years, 4 months ago
Reviewers:
jsbell
CC:
chromium-reviews, darin-cc_chromium.org, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[IndexedDB]: Passing URLRequestContextGetter. Indexed DB was passing net::URLRequestContext as it was needed for Blob writing in WriteBlobToFileOnIOThread. This switches to passing the *Getter which facilitates the move to Mojo where initialization is done on the Indexed DB thread. BUG=627484 Committed: https://crrev.com/95032d5b02ec93895c40dfbea1eea40d0aff45e9 Cr-Commit-Position: refs/heads/master@{#412585}

Patch Set 1 #

Patch Set 2 : clang-format and lint changes. #

Patch Set 3 : Fixed a few missed merge conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -188 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.h View 1 6 chunks +13 lines, -12 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 9 chunks +16 lines, -17 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 9 chunks +23 lines, -20 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc View 1 2 8 chunks +13 lines, -16 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 1 4 chunks +1 line, -8 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 2 6 chunks +5 lines, -33 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory.h View 1 4 chunks +21 lines, -18 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_impl.h View 1 4 chunks +12 lines, -9 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_impl.cc View 1 7 chunks +15 lines, -13 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_fake_backing_store.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/indexed_db/mock_indexed_db_factory.h View 1 2 3 chunks +48 lines, -40 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
cmumford
4 years, 5 months ago (2016-07-22 14:20:00 UTC) #6
cmumford
Swapping reviewers: jsbell for michaeln.
4 years, 5 months ago (2016-07-22 19:57:56 UTC) #8
jsbell
lgtm
4 years, 5 months ago (2016-07-22 20:14:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172863002/1
4 years, 5 months ago (2016-07-22 20:21:02 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/223635)
4 years, 5 months ago (2016-07-22 20:27:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172863002/20001
4 years, 4 months ago (2016-08-17 16:22:51 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/209110) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-17 16:31:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172863002/40001
4 years, 4 months ago (2016-08-17 18:07:58 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-17 18:12:19 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 18:16:14 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95032d5b02ec93895c40dfbea1eea40d0aff45e9
Cr-Commit-Position: refs/heads/master@{#412585}

Powered by Google App Engine
This is Rietveld 408576698