Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2172843002: Fix touchpad zoom on touchscreen Windows devices. (Closed)

Created:
4 years, 5 months ago by ananta
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix touchpad zoom on touchscreen Windows devices. TouchPad pinch to zoom on Windows typically works via a WM_MOUSEWHEEL message with the CONTROL flag in wParam and varying deltas. On touchscreen Windows devices like Surface, the WM_MOUSEWHEEL event is flagged as a synthesized message occurring due to a touch. I think it is safe to allow all WM_MOUSEWHEEL events to be processed by ignoring the touch flag as they don't appear to get synthesized via standard touch scrolls. Changes in this patch are as below: 1. Ignore the touch flag on WM_MOUSEWHEEL and WM_MOUSEHWHEEL messages. 2. Removed dead code in hwnd_message_handler.cc/.h which tried to set scroll styles on the window. BUG=620182 Committed: https://crrev.com/b4480ddac51c6c5e195ca5a14f5ef35a27b9865a Cr-Commit-Position: refs/heads/master@{#407240}

Patch Set 1 #

Patch Set 2 : Remove the AddScrollStylesToWindow function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -110 lines) Patch
M ui/views/win/hwnd_message_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 8 chunks +6 lines, -107 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
ananta
4 years, 5 months ago (2016-07-21 23:31:26 UTC) #2
sky
LGTM
4 years, 5 months ago (2016-07-22 16:21:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172843002/20001
4 years, 5 months ago (2016-07-22 19:14:20 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 20:11:10 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 20:14:12 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4480ddac51c6c5e195ca5a14f5ef35a27b9865a
Cr-Commit-Position: refs/heads/master@{#407240}

Powered by Google App Engine
This is Rietveld 408576698