Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: public/web/WebFrameClient.h

Issue 217283004: Migrate addMessageToConsole API to WebFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/web/ChromeClientImpl.cpp ('K') | « Source/web/ChromeClientImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebFrameClient.h
diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h
index 2ea883eba0c4cb763adcdf1c7030b8f3020f8cca..29872ac30dfdcc15641b2c90b1a97724e047b5dc 100644
--- a/public/web/WebFrameClient.h
+++ b/public/web/WebFrameClient.h
@@ -74,6 +74,7 @@ class WebURL;
class WebURLLoader;
class WebURLResponse;
class WebWorkerPermissionClientProxy;
+struct WebConsoleMessage;
struct WebContextMenuData;
struct WebPluginParams;
struct WebRect;
@@ -147,6 +148,15 @@ public:
// Called when a watched CSS selector matches or stops matching.
virtual void didMatchCSS(WebLocalFrame*, const WebVector<WebString>& newlyMatchingSelectors, const WebVector<WebString>& stoppedMatchingSelectors) { }
+ // Console messages ----------------------------------------------------
+
+ // Whether or not we should report a detailed message for the given source.
+ virtual bool shouldReportDetailedMessageForSource(const WebString& source) { return false; }
+
+ // A new message was added to the console.
+ virtual void didAddMessageToConsole(
+ const WebConsoleMessage&, const WebString& sourceName, unsigned sourceLine, const WebString& stackTrace) { }
jochen (gone - plz use gerrit) 2014/03/31 10:03:05 all in one line plz
+
// Load commands -------------------------------------------------------
// The client should handle the navigation externally.
« Source/web/ChromeClientImpl.cpp ('K') | « Source/web/ChromeClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698