Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2172823002: Submit button does not show up on md-settings anymore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
diff --git a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
index eed3719c2c82ad2624acbd42ce693e2d6cad6339..e4d31f183a7e35dccd449c79d6b42e3aee8c3ad1 100644
--- a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
+++ b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
@@ -55,6 +55,10 @@
position: relative;
}
+ .digit-button.submit-button.submit-button-hidden {
+ display: none;
+ }
+
.digit-button .icon-container {
background: var(--paper-grey-400);
border-radius: 100px;
@@ -114,6 +118,13 @@
width: 180px;
}
+ #pin-input.submit-button-hidden {
+ border-bottom: 2px;
+ border-bottom-style: solid;
+ text-align: center;
+ width: 230px;
+ }
+
#pin-input[type=number]::-webkit-inner-spin-button,
#pin-input[type=number]::-webkit-outer-spin-button {
-webkit-appearance: none;
@@ -131,11 +142,13 @@
<div id="container-constrained-width">
<div class="row horizontal-center">
<input id="pin-input" type="[[computeInputType_(enablePassword)]]"
- class$="[[computeInputClass_(value)]]"
+ class$="[[computeInputClass_(value)]]
+ [[computeSubmitHiddenClass_(enableSubmitButton)]]"
jdufault 2016/07/21 23:36:36 nit: align vertically so that the [[ line up.
sammiequon 2016/07/29 18:57:38 Done.
placeholder="[[computeInputPlaceholder_(enablePassword)]]"
value="{{value::input}}"
on-keydown="onInputKeyDown_"></input>
- <paper-button class="digit-button first-row submit-button"
+ <paper-button class$="digit-button first-row submit-button
+ [[computeSubmitHiddenClass_(enableSubmitButton)]]"
jdufault 2016/07/21 23:36:36 Rename computeSubmitHiddenClass_ to just computeSu
sammiequon 2016/07/29 18:57:38 Done.
on-tap="firePinSubmitEvent_">
<div class$="icon-container [[computeSubmitClass_(value)]]">
<iron-icon class="icon" icon="icons:forward"><iron-icon>

Powered by Google App Engine
This is Rietveld 408576698