Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2172823002: Submit button does not show up on md-settings anymore. (Closed)

Created:
4 years, 5 months ago by sammiequon
Modified:
4 years, 4 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Submit button does not show up on md-settings anymore. BUG=630385 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/419fade4f0ad45515ac29289034376833716e3e4 Cr-Commit-Position: refs/heads/master@{#409039}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebased. #

Patch Set 3 : Fixed patch set 1 errors. #

Total comments: 4

Patch Set 4 : Fixed patch set 3 errors. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -10 lines) Patch
M chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html View 1 2 3 3 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js View 1 2 3 3 chunks +25 lines, -4 lines 0 comments Download
M ui/login/account_picker/user_pod_template.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
sammiequon
jdufault@ - Please take a look.
4 years, 5 months ago (2016-07-21 22:51:16 UTC) #7
jdufault
https://codereview.chromium.org/2172823002/diff/60001/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right): https://codereview.chromium.org/2172823002/diff/60001/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html#newcode146 chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:146: [[computeSubmitHiddenClass_(enableSubmitButton)]]" nit: align vertically so that the [[ line ...
4 years, 5 months ago (2016-07-21 23:36:36 UTC) #8
sammiequon
https://codereview.chromium.org/2172823002/diff/60001/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right): https://codereview.chromium.org/2172823002/diff/60001/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html#newcode146 chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:146: [[computeSubmitHiddenClass_(enableSubmitButton)]]" On 2016/07/21 23:36:36, jdufault wrote: > nit: align ...
4 years, 4 months ago (2016-07-29 18:57:38 UTC) #9
jdufault
https://codereview.chromium.org/2172823002/diff/100001/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right): https://codereview.chromium.org/2172823002/diff/100001/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html#newcode151 chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:151: [[computeSubmitHiddenClass_(enableSubmitButton)]]" Fix wrapping; maybe rename the compute* to get*? ...
4 years, 4 months ago (2016-07-29 19:12:13 UTC) #10
sammiequon
https://codereview.chromium.org/2172823002/diff/100001/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right): https://codereview.chromium.org/2172823002/diff/100001/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html#newcode151 chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:151: [[computeSubmitHiddenClass_(enableSubmitButton)]]" On 2016/07/29 19:12:13, jdufault wrote: > Fix wrapping; ...
4 years, 4 months ago (2016-07-29 19:44:49 UTC) #11
jdufault
lgtm
4 years, 4 months ago (2016-07-30 06:33:34 UTC) #12
sammiequon
On 2016/07/30 06:33:34, jdufault wrote: > lgtm xiyuan@ - Please take a look.
4 years, 4 months ago (2016-08-01 16:55:21 UTC) #13
sammiequon
On 2016/08/01 16:55:21, sammiequon wrote: > On 2016/07/30 06:33:34, jdufault wrote: > > lgtm > ...
4 years, 4 months ago (2016-08-01 16:56:13 UTC) #15
xiyuan
lgtm
4 years, 4 months ago (2016-08-01 16:59:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172823002/140001
4 years, 4 months ago (2016-08-01 19:11:00 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:140001)
4 years, 4 months ago (2016-08-01 20:15:12 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 20:19:24 UTC) #23
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/419fade4f0ad45515ac29289034376833716e3e4
Cr-Commit-Position: refs/heads/master@{#409039}

Powered by Google App Engine
This is Rietveld 408576698