Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

Issue 2172753002: [DevTools] No longer store security origins in ResourceTreeModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Extracted security origins from the ResourceTreeModel Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
index 98c55294a0bb0e25cd6304f6a8dfec1db6e2d391..7c3593f53545ad6aa138d4fe7262cde09abb6a02 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
@@ -6,8 +6,10 @@
* Invariant: This model can only be constructed on a ServiceWorker target.
* @constructor
* @extends {WebInspector.SDKModel}
+ * @param {!WebInspector.Target} target
+ * @param {!WebInspector.SecurityOriginManager} securityOriginManager
*/
-WebInspector.ServiceWorkerCacheModel = function(target)
+WebInspector.ServiceWorkerCacheModel = function(target, securityOriginManager)
{
WebInspector.SDKModel.call(this, WebInspector.ServiceWorkerCacheModel, target);
@@ -16,6 +18,8 @@ WebInspector.ServiceWorkerCacheModel = function(target)
this._agent = target.cacheStorageAgent();
+ this._securityOriginManager = securityOriginManager;
+
/** @type {boolean} */
this._enabled = false;
}
@@ -31,10 +35,10 @@ WebInspector.ServiceWorkerCacheModel.prototype = {
if (this._enabled)
return;
- this.target().resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginAdded, this._securityOriginAdded, this);
- this.target().resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginRemoved, this._securityOriginRemoved, this);
+ this._securityOriginManager.addEventListener(WebInspector.SecurityOriginManager.EventTypes.SecurityOriginAdded, this._securityOriginAdded, this);
+ this._securityOriginManager.addEventListener(WebInspector.SecurityOriginManager.EventTypes.SecurityOriginRemoved, this._securityOriginRemoved, this);
- var securityOrigins = this.target().resourceTreeModel.securityOrigins();
+ var securityOrigins = this._securityOriginManager.securityOrigins();
for (var i = 0; i < securityOrigins.length; ++i)
this._addOrigin(securityOrigins[i]);
this._enabled = true;
@@ -54,7 +58,7 @@ WebInspector.ServiceWorkerCacheModel.prototype = {
for (var cache of this._caches.values())
this._cacheRemoved(cache);
this._caches.clear();
- var securityOrigins = this.target().resourceTreeModel.securityOrigins();
+ var securityOrigins = this._securityOriginManager.securityOrigins();
for (var securityOrigin of securityOrigins)
this._loadCacheNames(securityOrigin);
},
@@ -129,8 +133,8 @@ WebInspector.ServiceWorkerCacheModel.prototype = {
this._cacheRemoved(cache);
this._caches.clear();
if (this._enabled) {
- this.target().resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginAdded, this._securityOriginAdded, this);
- this.target().resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginRemoved, this._securityOriginRemoved, this);
+ this._securityOriginManager.removeEventListener(WebInspector.SecurityOriginManager.EventTypes.SecurityOriginAdded, this._securityOriginAdded, this);
+ this._securityOriginManager.removeEventListener(WebInspector.SecurityOriginManager.EventTypes.SecurityOriginRemoved, this._securityOriginRemoved, this);
}
},
@@ -325,12 +329,16 @@ WebInspector.ServiceWorkerCacheModel.Cache.prototype = {
WebInspector.ServiceWorkerCacheModel._symbol = Symbol("CacheStorageModel");
/**
* @param {!WebInspector.Target} target
- * @return {!WebInspector.ServiceWorkerCacheModel}
+ * @return {?WebInspector.ServiceWorkerCacheModel}
*/
WebInspector.ServiceWorkerCacheModel.fromTarget = function(target)
{
- if (!target[WebInspector.ServiceWorkerCacheModel._symbol])
- target[WebInspector.ServiceWorkerCacheModel._symbol] = new WebInspector.ServiceWorkerCacheModel(target);
+ if (!target[WebInspector.ServiceWorkerCacheModel._symbol]) {
dgozman 2016/07/22 03:27:03 Use the target.model(...) method.
eostroukhov-old 2016/07/22 23:27:44 Done.
+ var securityOriginManager = WebInspector.SecurityOriginManager.fromTarget(target);
+ if (!securityOriginManager)
dgozman 2016/07/22 03:27:03 It is never null. Instead, check for browser capab
eostroukhov-old 2016/07/22 23:27:44 Done.
+ return null;
+ target[WebInspector.ServiceWorkerCacheModel._symbol] = new WebInspector.ServiceWorkerCacheModel(target, securityOriginManager);
+ }
return target[WebInspector.ServiceWorkerCacheModel._symbol];
}

Powered by Google App Engine
This is Rietveld 408576698