[DevTools] No longer store security origins in ResourceTreeModel

third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.SDKModel}
+ * @param {!WebInspector.Target} target
+ * @param {!WebInspector.SecurityOriginManager} securityOriginManager
  */
-WebInspector.IndexedDBModel = function(target)
+WebInspector.IndexedDBModel = function(target, securityOriginManager)
 {
     WebInspector.SDKModel.call(this, WebInspector.IndexedDBModel, target);
+    this._resourceTreeModel = securityOriginManager;

[dgozman, 2016/07/22 03:27:02]

this._securityOriginManager

[eostroukhov-old, 2016/07/22 23:27:43]

Done.

     this._agent = target.indexedDBAgent();
 
     /** @type {!Map.<!WebInspector.IndexedDBModel.DatabaseId, !WebInspector.IndexedDBModel.Database>} */
     this._databases = new Map();
     /** @type {!Object.<string, !Array.<string>>} */
     this._databaseNamesBySecurityOrigin = {};
 }
 
 WebInspector.IndexedDBModel.KeyTypes = {
     NumberType:  "number",
     StringType:  "string",
     DateType:    "date",
     ArrayType:   "array"
 };
 
 WebInspector.IndexedDBModel.KeyPathTypes = {
     NullType:    "null",
     StringType:  "string",
     ArrayType:   "array"
 };
 
 /**
  * @param {*} idbKey
- * @return {?Object}
+ * @return {({

[dgozman, 2016/07/22 03:27:02]

nit: most of these () are unnecessary.

[eostroukhov-old, 2016/07/22 23:27:43]

Removing any of them gives compiler errors.

+ *   array: (!Array<?>|undefined),
+ *   date: (number|undefined),
+ *   number: (number|undefined),
+ *   string: (string|undefined),
+ *   type: !IndexedDBAgent.KeyType<string>
+ * }|undefined)}
  */
 WebInspector.IndexedDBModel.keyFromIDBKey = function(idbKey)
 {
     if (typeof(idbKey) === "undefined" || idbKey === null)
-        return null;
+        return undefined;
 
+    var type;
     var key = {};
     switch (typeof(idbKey)) {
     case "number":
         key.number = idbKey;
-        key.type = WebInspector.IndexedDBModel.KeyTypes.NumberType;
+        type = WebInspector.IndexedDBModel.KeyTypes.NumberType;
         break;
     case "string":
         key.string = idbKey;
-        key.type = WebInspector.IndexedDBModel.KeyTypes.StringType;
+        type = WebInspector.IndexedDBModel.KeyTypes.StringType;
         break;
     case "object":
         if (idbKey instanceof Date) {
             key.date = idbKey.getTime();
-            key.type = WebInspector.IndexedDBModel.KeyTypes.DateType;
+            type = WebInspector.IndexedDBModel.KeyTypes.DateType;
         } else if (Array.isArray(idbKey)) {
             key.array = [];
             for (var i = 0; i < idbKey.length; ++i)
                 key.array.push(WebInspector.IndexedDBModel.keyFromIDBKey(idbKey[i]));
-            key.type = WebInspector.IndexedDBModel.KeyTypes.ArrayType;
+            type = WebInspector.IndexedDBModel.KeyTypes.ArrayType;
         }
         break;
     default:
-        return null;
+        return undefined;
     }
+    key.type = /** @type {!IndexedDBAgent.KeyType<string>} */ (type);
     return key;
 }
 
 /**
  * @param {?IDBKeyRange=} idbKeyRange
- * @return {?{lower: ?Object, upper: ?Object, lowerOpen: *, upperOpen: *}}
+ * @return {?IndexedDBAgent.KeyRange}
+ * eturn {?{lower: ?Object, upper: ?Object, lowerOpen: *, upperOpen: *}}
  */
 WebInspector.IndexedDBModel.keyRangeFromIDBKeyRange = function(idbKeyRange)
 {
     if (typeof idbKeyRange === "undefined" || idbKeyRange === null)
         return null;
 
     var keyRange = {};
     keyRange.lower = WebInspector.IndexedDBModel.keyFromIDBKey(idbKeyRange.lower);
     keyRange.upper = WebInspector.IndexedDBModel.keyFromIDBKey(idbKeyRange.upper);
-    keyRange.lowerOpen = idbKeyRange.lowerOpen;
-    keyRange.upperOpen = idbKeyRange.upperOpen;
+    keyRange.lowerOpen = !!idbKeyRange.lowerOpen;
+    keyRange.upperOpen = !!idbKeyRange.upperOpen;
     return keyRange;
 }
 
 /**
  * @param {!IndexedDBAgent.KeyPath} keyPath
  * @return {?string|!Array.<string>|undefined}
  */
 WebInspector.IndexedDBModel.idbKeyPathFromKeyPath = function(keyPath)
 {
     var idbKeyPath;
@@ skipping 30 matching lines @@
     DatabaseLoaded: "DatabaseLoaded"
 }
 
 WebInspector.IndexedDBModel.prototype = {
     enable: function()
     {
         if (this._enabled)
             return;
 
         this._agent.enable();
+        this._resourceTreeModel.addEventListener(WebInspector.SecurityOriginManager.EventTypes.SecurityOriginAdded, this._securityOriginAdded, this);
+        this._resourceTreeModel.addEventListener(WebInspector.SecurityOriginManager.EventTypes.SecurityOriginRemoved, this._securityOriginRemoved, this);
 
-        this.target().resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginAdded, this._securityOriginAdded, this);
-        this.target().resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginRemoved, this._securityOriginRemoved, this);
-
-        var securityOrigins = this.target().resourceTreeModel.securityOrigins();
+        var securityOrigins = this._resourceTreeModel.securityOrigins();
         for (var i = 0; i < securityOrigins.length; ++i)
             this._addOrigin(securityOrigins[i]);
 
         this._enabled = true;
     },
 
     /**
      * @param {string} origin
      */
     clearForOrigin: function(origin)
@@ skipping 350 matching lines @@
      * @type {string}
      */
     get keyPathString()
     {
         return WebInspector.IndexedDBModel.keyPathStringFromIDBKeyPath(this.keyPath);
     }
 }
 
 /**
  * @param {!WebInspector.Target} target
- * @return {?WebInspector.IndexedDBModel}
+ * @return {!WebInspector.IndexedDBModel}
  */
 WebInspector.IndexedDBModel.fromTarget = function(target)
 {
     var model = /** @type {?WebInspector.IndexedDBModel} */ (target.model(WebInspector.IndexedDBModel));
-    if (!model)
-        model = new WebInspector.IndexedDBModel(target);
+    if (!model) {

[dgozman, 2016/07/22 03:27:02]

style: unnecessary {}

[eostroukhov-old, 2016/07/22 23:27:43]

Done.

+        model = new WebInspector.IndexedDBModel(target, WebInspector.SecurityOriginManager.fromTarget(target));
+    }
     return model;
 }