[DevTools] No longer store security origins in ResourceTreeModel

third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.AppManifestView = function()
@@ skipping 34 matching lines @@
     WebInspector.targetManager.observeTargets(this);
 }
 
 WebInspector.AppManifestView.prototype = {
     /**
      * @override
      * @param {!WebInspector.Target} target
      */
     targetAdded: function(target)
     {
-        if (this._target)
+        if (this._resourceTreeModel)
             return;
-        this._target = target;
-
-        this._updateManifest();
-        WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._updateManifest, this);
+        var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);
+        if (resourceTreeModel) {

[dgozman, 2016/07/22 03:27:02]

Let's observe DOM capability and assert here instead.

[eostroukhov-old, 2016/07/22 23:27:43]

Done.

+            this._resourceTreeModel = resourceTreeModel;
+            this._updateManifest();
+            resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._updateManifest, this);
+        }
     },
 
     /**
      * @override
      * @param {!WebInspector.Target} target
      */
     targetRemoved: function(target)
     {
     },
 
     _updateManifest: function()
     {
-        this._target.resourceTreeModel.fetchAppManifest(this._renderManifest.bind(this));
+        if (this._resourceTreeModel)

[dgozman, 2016/07/22 03:27:02]

Judging by previous code, this method is never called without resourceTreeModel.

[eostroukhov-old, 2016/07/22 23:27:43]

Done.

+            this._resourceTreeModel.fetchAppManifest(this._renderManifest.bind(this));
     },
 
     /**
      * @param {string} url
      * @param {?string} data
      * @param {!Array<!PageAgent.AppManifestError>} errors
      */
     _renderManifest: function(url, data, errors)
     {
         this._reportView.setURL(url);
@@ skipping 49 matching lines @@
     {
         var target = WebInspector.targetManager.mainTarget();
         if (target && target.hasBrowserCapability()) {
             target.pageAgent().requestAppBanner();
             WebInspector.console.show();
         }
     },
 
     __proto__: WebInspector.VBox.prototype
 }