[DevTools] No longer store security origins in ResourceTreeModel

[DevTools] No longer store security origins in RTM

This refactoring decouples storage models from the ResourceTreeModel.

BUG=624494
R=dgozman, pfeldman

Committed: https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41
Cr-Commit-Position: refs/heads/master@{#407678}

[eostroukhov-old, 2016-07-21 20:29:53]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 20:30:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov-old, 2016-07-21 20:31:03]

Please review - I am currently trying to break the big CLs into smaller ones.

[commit-bot: I haz the power, 2016-07-21 20:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:32:33]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[dgozman, 2016-07-21 21:53:48]

I think we should split security origins from resource tree model, and make the
latter be guarded by DOM capability.

[eostroukhov-old, 2016-07-21 23:34:04]

Extracted security origins from the ResourceTreeModel

[eostroukhov-old, 2016-07-21 23:34:07]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 23:34:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov-old, 2016-07-21 23:36:02]

Description was changed from

==========
[DevTools] Make the dependency more explicit

In order to make ResourceTreeModel optional, some refactorings need to
be made so it becomes clear where it is reqiured and where it is
optional.

BUG=624494
R=dgozman, pfeldman
==========

to

==========
[DevTools] No longer store security origins in RTM

This refactoring decouples storage models from the ResourceTreeModel.

BUG=624494
R=dgozman, pfeldman
==========

[eostroukhov-old, 2016-07-21 23:36:33]

I refactored the code. Please take another look.

[commit-bot: I haz the power, 2016-07-22 01:00:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 01:00:31]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-07-22 03:27:03]

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-data.html
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-data.html:8:
var indexedDBModel = new
WebInspector.IndexedDBModel(WebInspector.targetManager.mainTarget(),
WebInspector.SecurityOriginManager.fromTarget(WebInspector.targetManager.mainTarget()));
Let's introduce InspectorTest.securityOriginManager (similar to other models
there).

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:58: if
(resourceTreeModel) {
Let's observe DOM capability and assert here instead.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:75: if
(this._resourceTreeModel)
Judging by previous code, this method is never called without resourceTreeModel.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:74:
this._updateOrigin((resourceTreeModel && resourceTreeModel.mainFrame) ?
resourceTreeModel.mainFrame.url : "");
We should use securityOriginManager.mainSecurityOrigin() here.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:75:
WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated,
this._updateFrame, this);
And listen to SecurityOriginChanged event.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js:40:
this._resourceTreeModel = securityOriginManager;
this._securityOriginManager

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js:64: *
@return {({
nit: most of these () are unnecessary.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js:550: if
(!model) {
style: unnecessary {}

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:129: if
(!resourceTreeModel)
This will break for service worker: all storage subviews can totally work with
just securityOriginManager and without resourceTreeModel.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:182:
this._populateDOMStorageTree();
Let's pass domStorageModel explicitly.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1590:
var targets =
WebInspector.targetManager.targets(WebInspector.Target.Capability.DOM);
IndexedDB is not DOM, but Browser.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1616:
var targets =
WebInspector.targetManager.targets(WebInspector.Target.Capability.DOM);
ditto

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:2163:
if (!resourceTreeModel)
It cannot be null here.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:100: if
(resourceTreeModel)
Use DOM capability instead.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:114: var
mainFrame = resourceTreeModel && resourceTreeModel.mainFrame;
ditto

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:2: *
Copyright (C) 2016 Google Inc. All rights reserved.
New-style copyright is 3 lines.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:40:
this._securityOriginFrameCount = {};
Make it a Map.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:66: if
(!this._securityOriginFrameCount[securityOrigin]) {
_securityOriginCounter

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:75: *
@param {string|undefined} securityOrigin
Why undefined? Where does it come from?

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js:336:
if (!target[WebInspector.ServiceWorkerCacheModel._symbol]) {
Use the target.model(...) method.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js:338:
if (!securityOriginManager)
It is never null. Instead, check for browser capability.

[eostroukhov-old, 2016-07-22 23:11:54]

Comments were addressed

[eostroukhov-old, 2016-07-22 23:11:56]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 23:12:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov-old, 2016-07-22 23:27:44]

Thank you for the review. I addressed the comments. Please take another look.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-data.html
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-data.html:8:
var indexedDBModel = new
WebInspector.IndexedDBModel(WebInspector.targetManager.mainTarget(),
WebInspector.SecurityOriginManager.fromTarget(WebInspector.targetManager.mainTarget()));
On 2016/07/22 03:27:02, dgozman wrote:
> Let's introduce InspectorTest.securityOriginManager (similar to other models
> there).

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:58: if
(resourceTreeModel) {
On 2016/07/22 03:27:02, dgozman wrote:
> Let's observe DOM capability and assert here instead.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:75: if
(this._resourceTreeModel)
On 2016/07/22 03:27:02, dgozman wrote:
> Judging by previous code, this method is never called without
resourceTreeModel.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:74:
this._updateOrigin((resourceTreeModel && resourceTreeModel.mainFrame) ?
resourceTreeModel.mainFrame.url : "");
On 2016/07/22 03:27:02, dgozman wrote:
> We should use securityOriginManager.mainSecurityOrigin() here.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:75:
WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated,
this._updateFrame, this);
On 2016/07/22 03:27:02, dgozman wrote:
> And listen to SecurityOriginChanged event.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js:40:
this._resourceTreeModel = securityOriginManager;
On 2016/07/22 03:27:02, dgozman wrote:
> this._securityOriginManager

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js:64: *
@return {({
On 2016/07/22 03:27:02, dgozman wrote:
> nit: most of these () are unnecessary.

Removing any of them gives compiler errors.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js:550: if
(!model) {
On 2016/07/22 03:27:02, dgozman wrote:
> style: unnecessary {}

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:129: if
(!resourceTreeModel)
On 2016/07/22 03:27:02, dgozman wrote:
> This will break for service worker: all storage subviews can totally work with
> just securityOriginManager and without resourceTreeModel.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:182:
this._populateDOMStorageTree();
On 2016/07/22 03:27:02, dgozman wrote:
> Let's pass domStorageModel explicitly.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1590:
var targets =
WebInspector.targetManager.targets(WebInspector.Target.Capability.DOM);
On 2016/07/22 03:27:02, dgozman wrote:
> IndexedDB is not DOM, but Browser.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1616:
var targets =
WebInspector.targetManager.targets(WebInspector.Target.Capability.DOM);
On 2016/07/22 03:27:02, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:2163:
if (!resourceTreeModel)
On 2016/07/22 03:27:02, dgozman wrote:
> It cannot be null here.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:100: if
(resourceTreeModel)
On 2016/07/22 03:27:02, dgozman wrote:
> Use DOM capability instead.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:114: var
mainFrame = resourceTreeModel && resourceTreeModel.mainFrame;
On 2016/07/22 03:27:03, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:2: *
Copyright (C) 2016 Google Inc. All rights reserved.
On 2016/07/22 03:27:03, dgozman wrote:
> New-style copyright is 3 lines.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:40:
this._securityOriginFrameCount = {};
On 2016/07/22 03:27:03, dgozman wrote:
> Make it a Map.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:66: if
(!this._securityOriginFrameCount[securityOrigin]) {
On 2016/07/22 03:27:03, dgozman wrote:
> _securityOriginCounter

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:75: *
@param {string|undefined} securityOrigin
On 2016/07/22 03:27:03, dgozman wrote:
> Why undefined? Where does it come from?

Copy/paste error - sorry...

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
(right):

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js:336:
if (!target[WebInspector.ServiceWorkerCacheModel._symbol]) {
On 2016/07/22 03:27:03, dgozman wrote:
> Use the target.model(...) method.

Done.

https://codereview.chromium.org/2172753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js:338:
if (!securityOriginManager)
On 2016/07/22 03:27:03, dgozman wrote:
> It is never null. Instead, check for browser capability.

Done.

[dgozman, 2016-07-22 23:44:23]

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
(right):

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:45:
WebInspector.targetManager.observeTargets(this,
WebInspector.Target.Capability.DOM);
ClearStorageView is not about DOM.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:73:
var SecurityOriginManager =
WebInspector.SecurityOriginManager.fromTarget(target);
style: lowercase first character.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:75:
SecurityOriginManager.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated,
this._updateFrame, this);
There is no such event. And maybe no test for this view?

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:81:
_updateFrame: function(event)
Rename the method.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js
(right):

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:21:
SecurityOriginChanged: "SecurityOriginChanged",
MainSecurityOriginChanged

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:70:
return Array.from(this._securityOriginCounter.keys());
Is there a keysArray() method defined in utilities.js?

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
(right):

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js:333:
if (!target.hasAllCapabilities(WebInspector.Target.Capability.Browser))
hasBrowserCapability()

[commit-bot: I haz the power, 2016-07-23 01:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 01:25:21]

Dry run: This issue passed the CQ dry run.

[eostroukhov-old, 2016-07-25 18:15:39]

Addressed the comments

[eostroukhov-old, 2016-07-25 18:15:42]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 18:16:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov-old, 2016-07-25 18:16:59]

Thank you for the review. I've updated the CL, please take another look.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
(right):

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:45:
WebInspector.targetManager.observeTargets(this,
WebInspector.Target.Capability.DOM);
On 2016/07/22 23:44:22, dgozman wrote:
> ClearStorageView is not about DOM.

Done.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:73:
var SecurityOriginManager =
WebInspector.SecurityOriginManager.fromTarget(target);
On 2016/07/22 23:44:22, dgozman wrote:
> style: lowercase first character.

Done.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:75:
SecurityOriginManager.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated,
this._updateFrame, this);
On 2016/07/22 23:44:22, dgozman wrote:
> There is no such event. And maybe no test for this view?

Done.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:81:
_updateFrame: function(event)
On 2016/07/22 23:44:22, dgozman wrote:
> Rename the method.

Done.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js
(right):

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:21:
SecurityOriginChanged: "SecurityOriginChanged",
On 2016/07/22 23:44:23, dgozman wrote:
> MainSecurityOriginChanged

Done.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js:70:
return Array.from(this._securityOriginCounter.keys());
On 2016/07/22 23:44:23, dgozman wrote:
> Is there a keysArray() method defined in utilities.js?

Done.

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
(right):

https://codereview.chromium.org/2172753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js:333:
if (!target.hasAllCapabilities(WebInspector.Target.Capability.Browser))
On 2016/07/22 23:44:23, dgozman wrote:
> hasBrowserCapability()

Done.

[dgozman, 2016-07-25 18:56:09]

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js
(right):

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js:102:
InspectorTest.createIndexedDBModel = function() {
style: { on next line

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
(right):

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:75:
WebInspector.targetManager.addEventListener(WebInspector.SecurityOriginManager.EventTypes.MainSecurityOriginChanged,
this._originChanged, this);
There is no such event on TargetManager.

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
(right):

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js:365:
target[WebInspector.DOMStorageModel._symbol] = new
WebInspector.DOMStorageModel(target,
WebInspector.SecurityOriginManager.fromTarget(target));
Let's use target.model().

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1327:
if (target) {
nit: if (!target) return;

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1594:
if (!indexedDBModel)
There must be one for Browser capability.

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1620:
if (indexedDBModel)
ditto

[commit-bot: I haz the power, 2016-07-25 19:37:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 19:37:47]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[eostroukhov-old, 2016-07-25 19:46:47]

Comments

[eostroukhov-old, 2016-07-25 19:46:56]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 19:47:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov-old, 2016-07-25 19:47:48]

Thank you for the review. The CL was updated. PTAL.

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js
(right):

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js:102:
InspectorTest.createIndexedDBModel = function() {
On 2016/07/25 18:56:08, dgozman wrote:
> style: { on next line

Done.

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
(right):

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js:75:
WebInspector.targetManager.addEventListener(WebInspector.SecurityOriginManager.EventTypes.MainSecurityOriginChanged,
this._originChanged, this);
On 2016/07/25 18:56:08, dgozman wrote:
> There is no such event on TargetManager.

Done.

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
(right):

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js:365:
target[WebInspector.DOMStorageModel._symbol] = new
WebInspector.DOMStorageModel(target,
WebInspector.SecurityOriginManager.fromTarget(target));
On 2016/07/25 18:56:08, dgozman wrote:
> Let's use target.model().

Done.

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1327:
if (target) {
On 2016/07/25 18:56:08, dgozman wrote:
> nit: if (!target) return;

Done.

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1594:
if (!indexedDBModel)
On 2016/07/25 18:56:09, dgozman wrote:
> There must be one for Browser capability.

Done.

https://codereview.chromium.org/2172753002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1620:
if (indexedDBModel)
On 2016/07/25 18:56:08, dgozman wrote:
> ditto

Done.

[commit-bot: I haz the power, 2016-07-25 21:29:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 21:29:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[eostroukhov-old, 2016-07-25 22:35:53]

Fixed test failures

[eostroukhov-old, 2016-07-25 22:35:56]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 22:36:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-07-25 22:43:59]

lgtm

[eostroukhov-old, 2016-07-25 23:32:12]

The CQ bit was unchecked by eostroukhov@google.com

[eostroukhov-old, 2016-07-25 23:32:13]

The CQ bit was checked by eostroukhov@google.com

[commit-bot: I haz the power, 2016-07-25 23:32:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 01:41:45]

Description was changed from

==========
[DevTools] No longer store security origins in RTM

This refactoring decouples storage models from the ResourceTreeModel.

BUG=624494
R=dgozman, pfeldman
==========

to

==========
[DevTools] No longer store security origins in RTM

This refactoring decouples storage models from the ResourceTreeModel.

BUG=624494
R=dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-07-26 01:41:47]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-26 01:43:55]

Description was changed from

==========
[DevTools] No longer store security origins in RTM

This refactoring decouples storage models from the ResourceTreeModel.

BUG=624494
R=dgozman, pfeldman
==========

to

==========
[DevTools] No longer store security origins in RTM

This refactoring decouples storage models from the ResourceTreeModel.

BUG=624494
R=dgozman, pfeldman

Committed: https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41
Cr-Commit-Position: refs/heads/master@{#407678}
==========

[commit-bot: I haz the power, 2016-07-26 01:43:57]

Patchset 6 (id:??) landed as
https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41
Cr-Commit-Position: refs/heads/master@{#407678}