Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2373)

Unified Diff: build/config/ios/rules.gni

Issue 2172733003: Add ${target}+bundle to ios_framework_bundle template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-framework-bundle-info-plist
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 144916ca03e3a764ce7221c82fb198d8bde2d4f0..7f808eca97adbe2166005da17eb63e0c36ead093 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -848,6 +848,7 @@ template("ios_framework_bundle") {
visibility = [
":$_target_name$_toolchain_suffix",
":$_target_name+link$_toolchain_suffix",
+ ":$_target_name+bundle$_toolchain_suffix",
]
configs += [ ":$_headers_map_config$_toolchain_suffix" ]
@@ -892,6 +893,25 @@ template("ios_framework_bundle") {
]
}
}
+
+ if (!_is_fat_build || _is_fat_build_main_target) {
justincohen 2016/07/21 18:34:51 I'm seeing `!_is_fat_build || _is_fat_build_main_t
+ bundle_data(_target_name + "+bundle") {
+ forward_variables_from(invoker,
+ [
+ "testonly",
+ "visibility",
+ ])
+ public_deps = [
+ ":$_framework_target",
+ ]
+ sources = [
+ "$root_out_dir/$_output_name.framework",
+ ]
+ outputs = [
+ "{{bundle_resources_dir}}/Frameworks/$_output_name.framework",
+ ]
+ }
+ }
}
set_defaults("ios_framework_bundle") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698