Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 217273004: Pull GN @ r262225 (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org, dmikurube+memory_chromium.org
Visibility:
Public.

Description

Pull GN @ r262225 Implement GN visibility in the build, which this new version implements BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262438

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M base/allocator/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/nspr/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/symbolize/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/xdg_mime/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/xdg_user_dirs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/linux/pkg_config.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M build/toolchain/nacl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/bin/linux/gn.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/linux/gn32.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/mac/gn.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/win/gn.exe.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/testing/gtest/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/gn/secondary/tools/grit/grit_rule.gni View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
This requires https://codereview.chromium.org/46313003/ plus a binary push.
6 years, 9 months ago (2014-03-28 21:08:31 UTC) #1
scottmg
lgtm https://codereview.chromium.org/217273004/diff/1/tools/gn/secondary/tools/grit/grit_rule.gni File tools/gn/secondary/tools/grit/grit_rule.gni (right): https://codereview.chromium.org/217273004/diff/1/tools/gn/secondary/tools/grit/grit_rule.gni#newcode59 tools/gn/secondary/tools/grit/grit_rule.gni:59: # Only our generated static library can use ...
6 years, 8 months ago (2014-04-01 06:19:21 UTC) #2
brettw
6 years, 8 months ago (2014-04-08 16:50:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r262438 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698