Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2172723003: [cleanup] Remove some leftover strong mode code from the parser (Closed)

Created:
4 years, 5 months ago by adamk
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove some leftover strong mode code from the parser R=littledan@chromium.org Committed: https://crrev.com/88707c98b4647036f23fd796c7a33466364fee77 Cr-Commit-Position: refs/heads/master@{#37958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M src/parsing/parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser-base.h View 7 chunks +0 lines, -29 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
adamk
4 years, 5 months ago (2016-07-21 21:00:12 UTC) #1
Dan Ehrenberg
lgtm
4 years, 5 months ago (2016-07-21 22:43:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172723003/1
4 years, 5 months ago (2016-07-21 22:50:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 22:52:01 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:53:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88707c98b4647036f23fd796c7a33466364fee77
Cr-Commit-Position: refs/heads/master@{#37958}

Powered by Google App Engine
This is Rietveld 408576698