Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2172713003: TaskScheduler: Set the current SequenceToken when a Task runs. (Closed)

Created:
4 years, 5 months ago by fdoray
Modified:
4 years, 4 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@token
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler: Set the current SequenceToken when a Task runs. This allows SequenceCheckerImpl and ThreadCheckerImpl to work properly for tasks that run in base/task_scheduler. BUG=553459 Committed: https://crrev.com/4bf182a61163ae39bba91188697e265178e9b25b Cr-Commit-Position: refs/heads/master@{#407977}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase + CR robliao #4 (padding) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -57 lines) Patch
M base/task_scheduler/scheduler_worker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/sequence.h View 2 chunks +6 lines, -0 lines 0 comments Download
M base/task_scheduler/task_tracker.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M base/task_scheduler/task_tracker.cc View 1 3 chunks +10 lines, -2 lines 0 comments Download
M base/task_scheduler/task_tracker_unittest.cc View 1 21 chunks +96 lines, -51 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
fdoray
PTAL
4 years, 5 months ago (2016-07-21 21:05:06 UTC) #2
gab
lgtm :-)
4 years, 5 months ago (2016-07-22 13:50:11 UTC) #3
robliao
lgtm + nit https://codereview.chromium.org/2172713003/diff/1/base/task_scheduler/task_tracker_unittest.cc File base/task_scheduler/task_tracker_unittest.cc (right): https://codereview.chromium.org/2172713003/diff/1/base/task_scheduler/task_tracker_unittest.cc#newcode491 base/task_scheduler/task_tracker_unittest.cc:491: namespace { Nit: Padding one line ...
4 years, 5 months ago (2016-07-25 17:57:22 UTC) #4
fdoray
https://codereview.chromium.org/2172713003/diff/1/base/task_scheduler/task_tracker_unittest.cc File base/task_scheduler/task_tracker_unittest.cc (right): https://codereview.chromium.org/2172713003/diff/1/base/task_scheduler/task_tracker_unittest.cc#newcode491 base/task_scheduler/task_tracker_unittest.cc:491: namespace { On 2016/07/25 17:57:21, robliao wrote: > Nit: ...
4 years, 4 months ago (2016-07-26 20:44:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172713003/20001
4 years, 4 months ago (2016-07-26 22:33:57 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 23:48:55 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 23:53:42 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4bf182a61163ae39bba91188697e265178e9b25b
Cr-Commit-Position: refs/heads/master@{#407977}

Powered by Google App Engine
This is Rietveld 408576698