Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2172693002: Fix GPUTestConfigTest.LoadCurrentConfig on macOS Sierra. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GPUTestConfigTest.LoadCurrentConfig on macOS Sierra. The test needs to be updated each time Chrome begins to support a new macOS version. BUG=629708 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/af3ffdd21e5d85844ca1154d26431eff24ec7cf9 Cr-Commit-Position: refs/heads/master@{#406971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M gpu/config/gpu_test_config.h View 1 chunk +6 lines, -5 lines 0 comments Download
M gpu/config/gpu_test_config.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/config/gpu_test_expectations_parser.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M gpu/config/gpu_test_expectations_parser_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
erikchen
zmo: Please review.
4 years, 5 months ago (2016-07-21 17:10:27 UTC) #4
Zhenyao Mo
lgtm Thanks for fixing this. Sorry I wasn't able to get around to work on ...
4 years, 5 months ago (2016-07-21 17:19:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172693002/1
4 years, 5 months ago (2016-07-21 17:20:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/2165)
4 years, 5 months ago (2016-07-21 21:00:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172693002/1
4 years, 5 months ago (2016-07-21 21:09:11 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 22:35:18 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:37:09 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af3ffdd21e5d85844ca1154d26431eff24ec7cf9
Cr-Commit-Position: refs/heads/master@{#406971}

Powered by Google App Engine
This is Rietveld 408576698