Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2172683003: Include an empty breakpoints list on the Isolate response when the debugger is disabled. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include an empty breakpoints list on the Isolate response when the debugger is disabled. The protocol documentation claims this field is non-nullable and at least two clients assume it as well. BUG=http://dartbug.com/26938 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/fd63b906c02af936fff96b2e5e60aca16a779e1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M runtime/vm/isolate.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 5 months ago (2016-07-21 21:01:36 UTC) #2
Cutch
lgtm
4 years, 5 months ago (2016-07-21 21:28:02 UTC) #4
rmacnak
4 years, 5 months ago (2016-07-21 21:33:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd63b906c02af936fff96b2e5e60aca16a779e1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698