Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: services/tracing/public/cpp/tracing_impl.h

Issue 2172673002: Move Service packages from Mojo Applications -> Packages dir (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/public/service_manifest.gypi ('k') | services/tracing/public/cpp/tracing_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/tracing/public/cpp/tracing_impl.h
diff --git a/services/tracing/public/cpp/tracing_impl.h b/services/tracing/public/cpp/tracing_impl.h
index ed780e5ee4223d4d43a6d2d61c273ce657f32579..3408d820d54397dc303a22ef1afe99368a80e51d 100644
--- a/services/tracing/public/cpp/tracing_impl.h
+++ b/services/tracing/public/cpp/tracing_impl.h
@@ -17,29 +17,20 @@ class Connector;
namespace mojo {
-// Connects to mojo:tracing during your Application's Initialize() call once
-// per process.
-//
-// We need to deal with multiple ways of packaging mojo applications
-// together. We'll need to deal with packages that use the mojo.ContentHandler
-// interface to bundle several Applciations into a single physical on disk
-// mojo binary, and with those same services each in their own mojo binary.
-//
-// Have your bundle ContentHandler own a TracingImpl, and each Application own
-// a TracingImpl. In bundles, the second TracingImpl will be a no-op.
+// Connects to mojo:tracing during your Service's OnStart() call once per
+// process.
class TracingImpl : public shell::InterfaceFactory<tracing::TraceProvider> {
public:
TracingImpl();
~TracingImpl() override;
- // This connects to the tracing service and registers ourselves to provide
- // tracing data on demand.
+ // Connect to the Tracing service & provide tracing data on demand.
void Initialize(shell::Connector* connector, const std::string& url);
private:
// InterfaceFactory<tracing::TraceProvider> implementation.
void Create(shell::Connection* connection,
- InterfaceRequest<tracing::TraceProvider> request) override;
+ tracing::TraceProviderRequest request) override;
std::unique_ptr<shell::Connection> connection_;
TraceProviderImpl provider_impl_;
« no previous file with comments | « services/shell/public/service_manifest.gypi ('k') | services/tracing/public/cpp/tracing_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698