Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2172633002: Revert of Fix CronetHttpURLConnectionTest#testServerHangsUp flake (Closed)

Created:
4 years, 5 months ago by xunjieli
Modified:
4 years, 5 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix CronetHttpURLConnectionTest#testServerHangsUp flake (patchset #3 id:60001 of https://codereview.chromium.org/2164863002/ ) Reason for revert: Broke test on the bot. Original issue's description: > Fix CronetHttpURLConnectionTest#testServerHangsUp flake > > This CL makes the server to keep sending data, so when we > shut down the server, we are sure that it is still sending > (no eof has been sent). > > BUG=629591 > > Committed: https://crrev.com/056cabaa7714222bd67ecea221b7b3d4103752ee > Cr-Commit-Position: refs/heads/master@{#406833} TBR=pauljensen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629591 Committed: https://crrev.com/deb7784ea28328d178141c9eaad2e79dd6583a24 Cr-Commit-Position: refs/heads/master@{#406844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -54 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java View 1 chunk +10 lines, -1 line 0 comments Download
M components/cronet/android/test/native_test_server.cc View 7 chunks +0 lines, -47 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/NativeTestServer.java View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xunjieli
Created Revert of Fix CronetHttpURLConnectionTest#testServerHangsUp flake
4 years, 5 months ago (2016-07-21 14:25:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172633002/1
4 years, 5 months ago (2016-07-21 14:25:28 UTC) #3
pauljensen
lgtm
4 years, 5 months ago (2016-07-21 14:25:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 14:26:13 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 14:28:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/deb7784ea28328d178141c9eaad2e79dd6583a24
Cr-Commit-Position: refs/heads/master@{#406844}

Powered by Google App Engine
This is Rietveld 408576698