Add Optin Retry Logic to Google Now

Add Optin Retry Logic to Google Now

Bonus Fix:
fillFromChromeLocalStorage now handles undefined defaults correctly.

BUG=353703
R=rgustafson@chromium.org, skare@chromium.org, xiyuan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260294

[robliao, 2014-03-28 20:08:05]

Please review soon to get this into M35.

[rgustafson, 2014-03-28 20:59:48]

lgtm

https://codereview.chromium.org/217263005/diff/1/chrome/browser/resources/goo...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/217263005/diff/1/chrome/browser/resources/goo...
chrome/browser/resources/google_now/background.js:1118: * Sometimes we get the
response to the opted in result too soon during
Match the other function comment format. Start with a verb and explain what its
doing. Same with checkOptedIn.

[skare_, 2014-03-28 21:02:51]

lgtm

[robliao, 2014-03-28 21:03:06]

xiyuan: Please provide owner approval for this CL.

https://codereview.chromium.org/217263005/diff/1/chrome/browser/resources/goo...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/217263005/diff/1/chrome/browser/resources/goo...
chrome/browser/resources/google_now/background.js:1118: * Sometimes we get the
response to the opted in result too soon during
Done. checkOptedIn does start with a verb...
On 2014/03/28 20:59:48, rgustafson wrote:
> Match the other function comment format. Start with a verb and explain what
its
> doing. Same with checkOptedIn.

[robliao, 2014-03-28 21:05:08]

xiyuan: Please provide owner approval for this CL.

[rgustafson1, 2014-03-28 21:38:05]

I mean change it to "checks" rather than the useless words that preface
what it actualky does.
On Mar 28, 2014 2:05 PM, <robliao@chromium.org> wrote:

> xiyuan: Please provide owner approval for this CL.
>
> https://codereview.chromium.org/217263005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[robliao, 2014-03-28 21:47:12]

On 2014/03/28 21:38:05, rgustafson1 wrote:
> I mean change it to "checks" rather than the useless words that preface
> what it actualky does.
> On Mar 28, 2014 2:05 PM, <mailto:robliao@chromium.org> wrote:
> 
> > xiyuan: Please provide owner approval for this CL.
> >
> > https://codereview.chromium.org/217263005/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

This is to  distinguish it from requestOptIn. Performs works too.

[xiyuan, 2014-03-28 21:55:25]

lgtm

[robliao, 2014-03-28 21:59:26]

Committed patchset #3 manually as r260294 (presubmit successful).