Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 217263002: Move sockets manifest types to //extensions. (Closed)

Created:
6 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move sockets manifest types to //extensions. BUG=357648, 162530 TBR=rpaquay@chromium.org for sockets API Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260465

Patch Set 1 #

Total comments: 2

Patch Set 2 : copy #

Patch Set 3 : rename, add new "API" for extensionsManifestTypes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -1455 lines) Patch
M apps/shell/common/shell_extensions_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/manifest_types.json View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/common/extensions/api/sockets/sockets_manifest_data.h View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/common/extensions/api/sockets/sockets_manifest_data.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/common/extensions/api/sockets/sockets_manifest_handler.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/common/extensions/api/sockets/sockets_manifest_handler.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/common/extensions/api/sockets/sockets_manifest_permission.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/common/extensions/api/sockets/sockets_manifest_permission.cc View 1 chunk +0 lines, -369 lines 0 comments Download
D chrome/common/extensions/api/sockets/sockets_manifest_permission_unittest.cc View 1 chunk +0 lines, -403 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/manifest/sockets.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/sockets_tcp/sockets_tcp_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/api.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + extensions/common/api/extensions_manifest_types.json View 1 2 2 chunks +1 line, -193 lines 0 comments Download
A + extensions/common/api/sockets/sockets_manifest_data.h View 3 chunks +5 lines, -6 lines 0 comments Download
A + extensions/common/api/sockets/sockets_manifest_data.cc View 3 chunks +4 lines, -5 lines 0 comments Download
A + extensions/common/api/sockets/sockets_manifest_handler.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + extensions/common/api/sockets/sockets_manifest_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/common/api/sockets/sockets_manifest_permission.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/api/sockets/sockets_manifest_permission.cc View 1 2 12 chunks +53 lines, -47 lines 0 comments Download
A + extensions/common/api/sockets/sockets_manifest_permission_unittest.cc View 8 chunks +85 lines, -79 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Ken Rockot(use gerrit already)
kalman@ can you please take a look for the general change? jamescook@ for app shell ...
6 years, 9 months ago (2014-03-28 17:53:54 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/217263002/diff/1/extensions/common/api/manifest_types.json File extensions/common/api/manifest_types.json (right): https://codereview.chromium.org/217263002/diff/1/extensions/common/api/manifest_types.json#newcode2 extensions/common/api/manifest_types.json:2: // Use of this source code is governed ...
6 years, 9 months ago (2014-03-28 18:27:37 UTC) #2
James Cook
lgtm, but also curious about docs
6 years, 9 months ago (2014-03-28 19:39:41 UTC) #3
Ken Rockot(use gerrit already)
Good catch on the docs. They work now. Not crazy about naming of extensionsManifestTypes vs ...
6 years, 9 months ago (2014-03-28 19:48:20 UTC) #4
James Cook
On 2014/03/28 19:48:20, Ken Rockot wrote: > Good catch on the docs. They work now. ...
6 years, 9 months ago (2014-03-28 19:50:34 UTC) #5
Ken Rockot(use gerrit already)
> I'll defer to kalman at this point. (chromeManifestTypes also sounds better to > me, ...
6 years, 9 months ago (2014-03-28 19:52:34 UTC) #6
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-28 22:28:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/217263002/40001
6 years, 9 months ago (2014-03-28 22:49:36 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 00:38:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 00:38:15 UTC) #10
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-29 00:40:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/217263002/40001
6 years, 9 months ago (2014-03-29 00:42:18 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 02:19:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 02:19:05 UTC) #14
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-03-30 03:09:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/217263002/40001
6 years, 8 months ago (2014-03-30 03:09:53 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 04:44:49 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-30 04:44:49 UTC) #18
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-03-30 17:25:28 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/217263002/40001
6 years, 8 months ago (2014-03-30 17:25:56 UTC) #20
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 20:49:49 UTC) #21
Message was sent while issue was closed.
Change committed as 260465

Powered by Google App Engine
This is Rietveld 408576698