Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2172623002: Fixes small mistake in peerconnection-call-data.html (Closed)

Created:
4 years, 5 months ago by ehmaldonado
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes small mistake in peerconnection-call-data.html Lines 39 to 41 seem to declare a variable, instead of setting the transform method provided in webrtc_test_common.js BUG=6137 Committed: https://crrev.com/24c9f25faed643d576c684d48de74b426089586c Cr-Commit-Position: refs/heads/master@{#406859}

Patch Set 1 #

Patch Set 2 : Fixed another error of the same kind in peerconnection-call.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/test/data/media/peerconnection-call.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/media/peerconnection-call-data.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ehmaldonado_webrtc
4 years, 5 months ago (2016-07-21 14:22:20 UTC) #2
phoglund_chromium
lgtm
4 years, 5 months ago (2016-07-21 14:30:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172623002/20001
4 years, 5 months ago (2016-07-21 14:37:43 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 15:33:07 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 15:34:49 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24c9f25faed643d576c684d48de74b426089586c
Cr-Commit-Position: refs/heads/master@{#406859}

Powered by Google App Engine
This is Rietveld 408576698