Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2172603002: [wasm] ASM-2-WASM. Enforces switch default clause appearing last. (Closed)

Created:
4 years, 5 months ago by John
Modified:
4 years, 5 months ago
Reviewers:
bradnelson, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] ASM-2-WASM. Enforces switch default clause appearing last. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=628803 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer.cc LOG= N Committed: https://crrev.com/6f31bc9ce8d30dcb538097da099502bd976ef36c Cr-Commit-Position: refs/heads/master@{#37954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M src/asmjs/asm-typer.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
John
4 years, 5 months ago (2016-07-21 12:40:53 UTC) #6
aseemgarg
You might need to change the commit message. For all commits going in wasm, we ...
4 years, 5 months ago (2016-07-21 18:37:39 UTC) #7
bradnelson
lgtm Update commit message.
4 years, 5 months ago (2016-07-21 19:00:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172603002/1
4 years, 5 months ago (2016-07-21 19:00:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 19:02:04 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:03:50 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f31bc9ce8d30dcb538097da099502bd976ef36c
Cr-Commit-Position: refs/heads/master@{#37954}

Powered by Google App Engine
This is Rietveld 408576698