Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4017)

Unified Diff: chrome/browser/resources/md_history/browser_service.js

Issue 2172563002: [MD History] Use openForeignSession message to open foreign session tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_menu_up
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/browser_service.js
diff --git a/chrome/browser/resources/md_history/browser_service.js b/chrome/browser/resources/md_history/browser_service.js
index e8790aaeca2351e6ee276fbbd443074dd5b3364f..23c08ec8cf53eb5f10d4817124c738d4608df8b3 100644
--- a/chrome/browser/resources/md_history/browser_service.js
+++ b/chrome/browser/resources/md_history/browser_service.js
@@ -49,6 +49,27 @@ cr.define('md_history', function() {
chrome.send('removeBookmark', [url]);
},
+ /**
+ * @param {string} sessionTag
+ */
+ openForeignSessionAllTabs: function(sessionTag) {
+ chrome.send('openForeignSession', [sessionTag]);
+ },
+
+ /**
+ * @param {string} sessionTag
+ * @param {number} tabId
tsergeant 2016/07/22 03:21:16 Reorder these so they're the same order as the met
calamity 2016/07/27 05:22:06 Done.
+ * @param {number} windowId
+ * @param {Event} e
tsergeant 2016/07/22 03:21:16 Change this type to reflect that it's not any old
calamity 2016/07/27 05:22:06 Moved the event extraction up a level as discussed
+ */
+ openForeignSessionTab: function(sessionTag, windowId, tabId, e) {
+ var srcEvent = e.detail.sourceEvent;
+ chrome.send('openForeignSession', [
+ sessionTag, String(windowId), String(tabId), srcEvent.button || 0,
+ srcEvent.altKey, srcEvent.ctrlKey, srcEvent.metaKey, srcEvent.shiftKey
+ ]);
+ },
+
openClearBrowsingData: function() {
chrome.send('clearBrowsingData');
},

Powered by Google App Engine
This is Rietveld 408576698