scripts/slave/recipe_modules/chromium_tests/chromium_perf.py - Issue 2172553003: The second solution solution for ToT catapult.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

Issue 2172553003: The second solution solution for ToT catapult. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Passing gclient config name to BuildSpec. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json ('k') | scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py » ('j') | scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

index c9682d027e556d1bc503ac2d9a6afd230f76ee3a..a5d0c20b06892ad97a369b888cf5e601623c9367 100644

--- a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

@@ -19,7 +19,7 @@ SPEC = {

def _BaseSpec(bot_type, chromium_config, disable_tests,

- platform, target_bits, tests):

+ platform, target_bits, tests, gclient_config='chromium_perf'):

dtu 2016/08/10 01:19:39 Don't think we need a new parameter, we don't have

RobertoCN 2016/08/10 22:59:54 Done.

spec = {

'bot_type': bot_type,

'chromium_config': chromium_config,

@@ -28,7 +28,7 @@ def _BaseSpec(bot_type, chromium_config, disable_tests,

'TARGET_BITS': target_bits,

'disable_tests': disable_tests,

- 'gclient_config': 'chromium_perf',

+ 'gclient_config': gclient_config,

'testing': {

'platform': 'linux' if platform == 'android' else platform,

@@ -45,7 +45,8 @@ def _BaseSpec(bot_type, chromium_config, disable_tests,

return spec

-def BuildSpec(chromium_config, perf_id, platform, target_bits):

+def BuildSpec(chromium_config, perf_id, platform, target_bits,

+ gclient_config='chromium_perf'):

if platform == 'android':

# TODO: Run sizes on Android.

tests = []

@@ -58,7 +59,9 @@ def BuildSpec(chromium_config, perf_id, platform, target_bits):

disable_tests=True,

platform=platform,

target_bits=target_bits,

- tests=tests)

+ tests=tests,

+ gclient_config=gclient_config,

+ )

spec['compile_targets'] = ['chromium_builder_perf']