chrome/browser/policy/cloud/cloud_policy_browsertest.cc - Issue 2172543003: Remove NetPrefObserver class and two prefs that do not do anything.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/cloud_policy_browsertest.cc

Issue 2172543003: Remove NetPrefObserver class and two prefs that do not do anything. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re: #12. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/net_pref_observer.cc ('k') | chrome/browser/policy/configuration_policy_handler_list_factory.cc » ('j') | components/policy/resources/policy_templates.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/cloud_policy_browsertest.cc

diff --git a/chrome/browser/policy/cloud/cloud_policy_browsertest.cc b/chrome/browser/policy/cloud/cloud_policy_browsertest.cc

index 047c919dbdde816035ca34c258d15fad8c6276d8..105bf446dafcbb98a91f543b810e00de6e932d46 100644

--- a/chrome/browser/policy/cloud/cloud_policy_browsertest.cc

+++ b/chrome/browser/policy/cloud/cloud_policy_browsertest.cc

@@ -484,9 +484,11 @@ TEST(CloudPolicyProtoTest, VerifyProtobufEquivalence) {

list->add_entries("ftp");

list->add_entries("mailto");

// Try explicitly setting a policy mode too.

- chrome_settings.mutable_disablespdy()->set_disablespdy(false);

- chrome_settings.mutable_disablespdy()->mutable_policy_options()->set_mode(

- em::PolicyOptions::MANDATORY);

+ chrome_settings.mutable_searchsuggestenabled()->set_searchsuggestenabled(

+ false);

+ chrome_settings.mutable_searchsuggestenabled()

+ ->mutable_policy_options()

+ ->set_mode(em::PolicyOptions::MANDATORY);

chrome_settings.mutable_syncdisabled()->set_syncdisabled(true);

chrome_settings.mutable_syncdisabled()->mutable_policy_options()->set_mode(

em::PolicyOptions::RECOMMENDED);

@@ -499,9 +501,10 @@ TEST(CloudPolicyProtoTest, VerifyProtobufEquivalence) {

list = cloud_policy.mutable_disabledschemes()->mutable_value();

list->add_entries("ftp");

list->add_entries("mailto");

- cloud_policy.mutable_disablespdy()->set_value(false);

- cloud_policy.mutable_disablespdy()->mutable_policy_options()->set_mode(

- em::PolicyOptions::MANDATORY);

+ cloud_policy.mutable_searchsuggestenabled()->set_value(false);

+ cloud_policy.mutable_searchsuggestenabled()

+ ->mutable_policy_options()

+ ->set_mode(em::PolicyOptions::MANDATORY);

cloud_policy.mutable_syncdisabled()->set_value(true);

cloud_policy.mutable_syncdisabled()->mutable_policy_options()->set_mode(

em::PolicyOptions::RECOMMENDED);