Remove NetPrefObserver class and two prefs that do not do anything.

Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773, 334602
Committed: https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554
Cr-Commit-Position: refs/heads/master@{#407313}

[Bence, 2016-07-21 17:42:38]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 17:43:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 17:56:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 17:56:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bence, 2016-07-21 18:07:58]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 18:08:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:15:12]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-07-21 19:21:23]

bnc@chromium.org changed reviewers:
+ gab@chromium.org, mef@chromium.org, pastarmovj@chromium.org,
skuhne@chromium.org

[Bence, 2016-07-21 19:21:23]

Misha: PTAL at chrome/browser/net/
Julian: PTAL at chrome/browser/chromeos/policy/, at
chrome/browser/policy/cloud/, and at components/policy/.
Mr4D: PTAL at chrome/browser/profiles/.
Gab: PTAL at chrome/browser/prefs/.

Thank you all.

[Mr4D (OOO till 08-26), 2016-07-21 19:39:22]

profiles - lgtm

[gab, 2016-07-21 21:26:43]

https://codereview.chromium.org/2172543003/diff/20001/chrome/browser/net/net_...
File chrome/browser/net/net_pref_observer.cc (left):

https://codereview.chromium.org/2172543003/diff/20001/chrome/browser/net/net_...
chrome/browser/net/net_pref_observer.cc:33:
registry->RegisterBooleanPref(prefs::kDisableSpdy, false);
Move the definition of kDisableSpdy to browser_prefs.cc and add code in
MigrateObsoleteProfilePrefs to clear it (see how it's done for other prefs).

[Bence, 2016-07-21 23:17:05]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 23:17:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 23:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 23:34:10]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[pastarmovj, 2016-07-22 08:06:25]

LGTM with a nit.

P.S. If you need another review round due to large changes or something else
please seek another reviewer. I will be OOO until 8/16.

https://codereview.chromium.org/2172543003/diff/40001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2172543003/diff/40001/components/policy/resou...
components/policy/resources/policy_templates.json:400: 'desc': '''Enables
network prediction in <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> and
prevents users from changing this setting.
Please add to the description that this policy is deprecated and why just like
you did below for SPDY.

[Bence, 2016-07-22 13:24:31]

Description was changed from

==========
Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095
==========

to

==========
Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773
==========

[Bence, 2016-07-22 13:29:12]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 13:29:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 14:03:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 14:03:08]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-07-22 15:37:12]

bnc@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Bence, 2016-07-22 15:37:13]

Gab: PTAL.
Dan: PTAL at chrome/android/, chrome/browser/android/.  This is part of
https://crbug.com/526773.  See https://crbug.com/401970 for privacy approval. 
Thank you.

https://codereview.chromium.org/2172543003/diff/20001/chrome/browser/net/net_...
File chrome/browser/net/net_pref_observer.cc (left):

https://codereview.chromium.org/2172543003/diff/20001/chrome/browser/net/net_...
chrome/browser/net/net_pref_observer.cc:33:
registry->RegisterBooleanPref(prefs::kDisableSpdy, false);
On 2016/07/21 21:26:43, gab wrote:
> Move the definition of kDisableSpdy to browser_prefs.cc and add code in
> MigrateObsoleteProfilePrefs to clear it (see how it's done for other prefs).

Done.

[gab, 2016-07-22 16:44:33]

prefs lgtm

https://codereview.chromium.org/2172543003/diff/80001/chrome/common/pref_name...
File chrome/common/pref_names.cc (left):

https://codereview.chromium.org/2172543003/diff/80001/chrome/common/pref_name...
chrome/common/pref_names.cc:460: // is functioning as per crbug.com/334602.
Should crbug.com/334602 be listed in CL description?

[Bence, 2016-07-22 16:48:06]

Description was changed from

==========
Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773
==========

to

==========
Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773, 334602
==========

[gone, 2016-07-22 16:53:06]

android/ lgtm

[mef, 2016-07-22 20:03:06]

On 2016/07/22 16:53:06, dfalcantara wrote:
> android/ lgtm

chrome/browser/net/ lgtm

[Bence, 2016-07-23 00:16:30]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-07-23 00:16:30]

The patchset sent to the CQ was uploaded after l-g-t-m from skuhne@chromium.org,
pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2172543003/#ps80001
(title: "Re: #17.")

[Bence, 2016-07-23 00:16:42]

Thank you all.

https://codereview.chromium.org/2172543003/diff/80001/chrome/common/pref_name...
File chrome/common/pref_names.cc (left):

https://codereview.chromium.org/2172543003/diff/80001/chrome/common/pref_name...
chrome/common/pref_names.cc:460: // is functioning as per crbug.com/334602.
On 2016/07/22 16:44:33, gab wrote:
> Should crbug.com/334602 be listed in CL description?

Done.

[commit-bot: I haz the power, 2016-07-23 00:16:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 00:20:46]

Description was changed from

==========
Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773, 334602
==========

to

==========
Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773, 334602
==========

[commit-bot: I haz the power, 2016-07-23 00:20:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-23 00:22:36]

Description was changed from

==========
Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773, 334602
==========

to

==========
Remove NetPrefObserver class and two prefs that do not do anything.

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773, 334602

Committed: https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554
Cr-Commit-Position: refs/heads/master@{#407313}
==========

[commit-bot: I haz the power, 2016-07-23 00:22:38]

Patchset 5 (id:??) landed as
https://crrev.com/a376ed55e15fc38bb8d22fe164fb275882a37554
Cr-Commit-Position: refs/heads/master@{#407313}